Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp5069642ybb; Tue, 24 Mar 2020 10:23:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtpy0SJXsGRglwc4uLfMDrFqiV0r3OE0l1ym4FTATWlAAMAkv5+OSm56xxFIDUwzzchMlUj X-Received: by 2002:a05:6830:3151:: with SMTP id c17mr23996498ots.310.1585070594291; Tue, 24 Mar 2020 10:23:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585070594; cv=none; d=google.com; s=arc-20160816; b=ev5DTgm/hiEjLNxyzWvLidlnVnZMXzKfjXywSI6usP7Bp2NnD/NxB9zSRwElJ+yCbT /daCCSIMDOeIIJ9yOXpe2PJnvoXMj+3Z4hvTKBoHTGT0Gzt5YB31ujJ8tDo6cSCK7VPI IZ6G/E2ckRocgWgS37ccuN+fKutO300Z+5lMDDnARaa3hnE07MJDNoRAuoY0oqAF6oVn e6hw7mQZEpqyM9TuFhE9lu/VbQuj2OBIetxCC+dV0gNffMpUOTR7dh1kzhEeQlanHnWq +Q7orEvwOt2NtG4bqwMlbVlTMDeIYwjCAhWjLke1g19oEgmQ6ZP5cV4/38x2KnuE+HMA cj9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references; bh=P3K2WeEwyjC86c8wpeNcHwTP9MGsaghtAwk9U3gsTQg=; b=CmbPhlsLhVmkP93wQ0sOC12Fu5k5atFGzWgD3tAg9OdTnA6EdI6Pmwc5PXMbOYw2vg f0dBRN6Db6GDonfG5YSIG5QS5zEyVtBYl9OBpvoUGwQsv671aBL2JvGV7HUXgDJbLowh VmRAwYYSnPGvy+Lax8zZFb5I/03pjDsWnJtS28EW63vXXEof8QWa4fE3uExpSctIDUHP VIjEDMlspdlkSwNElyL6Z/vVYnylAY29H2+kzfF4far3Qx/VFLDDstBBvJHVmfOid79D P3Panh2I9JDzgq3tdyeTp4dXTf7Sjl9QMlWDcUWFsSDmCgd7Fl180GYEQMTiJtqdRgQ4 Rn0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x25si273022otk.160.2020.03.24.10.23.01; Tue, 24 Mar 2020 10:23:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727721AbgCXRVC (ORCPT + 99 others); Tue, 24 Mar 2020 13:21:02 -0400 Received: from foss.arm.com ([217.140.110.172]:38616 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727267AbgCXRVC (ORCPT ); Tue, 24 Mar 2020 13:21:02 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C77301FB; Tue, 24 Mar 2020 10:21:01 -0700 (PDT) Received: from e113632-lin (e113632-lin.cambridge.arm.com [10.1.194.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C651E3F71F; Tue, 24 Mar 2020 10:21:00 -0700 (PDT) References: <20200324125533.17447-1-valentin.schneider@arm.com> User-agent: mu4e 0.9.17; emacs 26.3 From: Valentin Schneider To: linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, morten.rasmussen@arm.com, mgorman@techsingularity.net Subject: Re: [PATCH] sched/topology: Fix overlapping sched_group build In-reply-to: <20200324125533.17447-1-valentin.schneider@arm.com> Date: Tue, 24 Mar 2020 17:20:52 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24 2020, Valentin Schneider wrote: > Fix > === > > Sanitize the groups we get out of build_group_from_child_sched_domain() > with the span of the domain we're currently building - this ensures the > groups we build only contain CPUs that are the right distance away from the > base CPU. This also requires modifying build_balance_mask(). > I somehow missed that this triggers the WARN_ON_ONCE() in init_overlap_sched_group(). Gotta figure out why.