Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp5126645ybb; Tue, 24 Mar 2020 11:22:22 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvq55drEmINUNj88UBtYVmYIKXCR/UsTNZEBKoi/jqmikq/poaTnBv9zUm9w2JpCv1g6z5W X-Received: by 2002:aca:4154:: with SMTP id o81mr4422567oia.125.1585074142304; Tue, 24 Mar 2020 11:22:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585074142; cv=none; d=google.com; s=arc-20160816; b=w3hCQEj2GNahTbolvtLqUtptER9mJf917CVgXzjsnTBpXQUFViUFS+amwaYk/OcsSC gwHRumXo81a1n8UEw1vo6FibWKzd6bXA8/3IsZxOhvYIs0LmXLyNTeezDxB9uVIHH7Mu XNYoTXDzOlkwNhQHI5eUnNT+MH4htYjHmYmKtWO7qDskuoevhSaiDwFVCDRBoVuVinBn 1QRHe8JIa8UdvW/+mXQX/Rx4ofpyQ2hlxcRQoYCGDzsy8zmxxJZMDtRUqdTD9sB1EUUM zIaPZ/Aac5Ulrq44H4rFIuN470vUoJVq5j7rTMerKYAo7HFV7Ai2/DfaY9pD876RxjxM f/eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pT25UnZw8GM7Hd21OQrxHvPDWru16NnMVVxodL4fKVA=; b=f1PAAVOt81a9AZjqaNkzHeFS+WNSS5HCRZcicyZiPqU3O8vxhLD1+HAnxHWq6aNWvl g7CI7B8TzrTYvWfe94uHS3oOdHA0VBHIYhcwv16sMMjp8gbzoQ6P63GII7d27EXQzDLC DKSSrvTbMBHJ5hkGENYnAh8Pe4xRUYWJekriDJBp/M06LCoXHeg7mC9MEoXUFgoBOL9+ sTuHnLLQ6r3IhSq3OY0h42VSZptgFVeGfUs3i1ZEtV4N0dPlXgtZQvPDR3nV/mu1Sfip ZPsXku9buRCpKFrr62CZSsrajUxqAuHfwV1tvZ2cOTVCe7mZcmase5I+74s258qAGwma atkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iyhktkum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o63si9566161oih.74.2020.03.24.11.22.00; Tue, 24 Mar 2020 11:22:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iyhktkum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728143AbgCXSU7 (ORCPT + 99 others); Tue, 24 Mar 2020 14:20:59 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:55724 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgCXSU6 (ORCPT ); Tue, 24 Mar 2020 14:20:58 -0400 Received: by mail-pj1-f65.google.com with SMTP id mj6so1952381pjb.5 for ; Tue, 24 Mar 2020 11:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pT25UnZw8GM7Hd21OQrxHvPDWru16NnMVVxodL4fKVA=; b=iyhktkumgD/jnOyy/wrt8dXzir+rVbxsCaX0F1NIU968y/5PKrYcKlaC+EUgsXxoD1 qRnZuBoGJVEq/iPtymBbiQq/d0t+3o76Vg7pmHHpXjJtM7UuE+MA3iFeocbUrYXAjiQM Z6sejDHA46aOnvzsmPK6WvTcsSKcktL/hzcag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pT25UnZw8GM7Hd21OQrxHvPDWru16NnMVVxodL4fKVA=; b=kobMJq0IJ+yGFTNYwlwuTlNcWYg3gGJmCAanoY7podpJxY0U2eK/+uJMMtbtAIKh8q m8xr/2TsYb8HeksqI8ZXx0UUKdnQm0RyvJRiFDVSx90s7zjwbY2FofucdkteSzfqkKre dUokTbHc2Q8hCJ88VSFa0ADUIcUd+4o/IH22bhDcpb7SywC598z6m/OYKoAGm5K88Qps YpEizR15zQJacqkJPGjljyUkw/gswdEB2aORjHrncdTXYID9f4kDe6DkZ24PHnURWhi1 Pq0zyw/04MuX5ISaot7n56usC2vhL6H9VTbDDnLYnfEvQmqYrgnMYgBbD189rDLXQikr 8HnQ== X-Gm-Message-State: ANhLgQ2XGUhh7Jqr+C8gZMbRFT7Vxx3LVj5xNRe35ZXMWziiVFiR4y/A nCUfwRJ1vV/rKvkGGx7sBYQvi3+EiEY= X-Received: by 2002:a17:90a:3349:: with SMTP id m67mr6643283pjb.175.1585074057290; Tue, 24 Mar 2020 11:20:57 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w31sm15114250pgl.84.2020.03.24.11.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 11:20:56 -0700 (PDT) Date: Tue, 24 Mar 2020 11:20:55 -0700 From: Kees Cook To: "Guilherme G. Piccoli" Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, mcgrof@kernel.org, yzaikin@google.com, tglx@linutronix.de, penguin-kernel@I-love.SAKURA.ne.jp, akpm@linux-foundation.org, cocci@systeme.lip6.fr, linux-api@vger.kernel.org, kernel@gpiccoli.net, randy Dunlap Subject: Re: [PATCH V2] kernel/hung_task.c: Introduce sysctl to print all traces when a hung task is detected Message-ID: <202003241119.A666E1C694@keescook> References: <20200323214618.28429-1-gpiccoli@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 09:45:40AM -0300, Guilherme G. Piccoli wrote: > Thanks Randy and Vlastimil for the comments. I really liked your > approach Vlastimil, I agree that we have no reason to not have a generic > sysctl setting via cmdline mechanism - I'll rework this patch removing > the kernel parameter (same for other patch I just submitted). I've been thinking we'll likely want to have a big patch series that removes all the old "duplicate" boot params and adds some kind of "alias" mechanism. Vlastimil, have you happened to keep a list of other "redundant" boot params you've noticed in the kernel? I bet there are a lot. :) -- Kees Cook