Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp5274517ybb; Tue, 24 Mar 2020 14:14:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtSg3b7qcBgy+a2LYfG+AM7AzXhB5shYToYA57LWxKd39Z9ApywGLXZB35Qo2wPsMI79mCe X-Received: by 2002:aca:4d8:: with SMTP id 207mr194417oie.70.1585084455335; Tue, 24 Mar 2020 14:14:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585084455; cv=none; d=google.com; s=arc-20160816; b=hRNqopYoKvqLzNVxNl2BdfdaLCdlDX8xJH0PZYsRtaHKUAkka9lALbT9pBTt1xvMDv Wl7ZAVRmF2jJcypG5NY+au8oUUaF9m4Klm2gL4E6C5gVdYRyLqWGaCB3zwgCGhnGxJfQ yPhGWmPdsoHX5DHjNCR8TrlTvFli9+Ygd3DQb3T4ynVUKHZ5Ed9PoQZyZSBjrDhi3s2+ k2GffBq3+oaBync07opKyzx+ZWAmIOfe3ennZ/JLMG+3mma47F+1kzBAJ/9eDVN9pRY5 kRxfeiMz6DLIsGt0l0tb1N17/xM03cCfQ330QRvBKZT+8dmBM7NQifWSG64bGAtUtKCB Fggg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=UBXTlfBB5V6oYxQxCHfMAgYy2LlHqpP4L4e/SUdnMD8=; b=MlDhHhHQOgIDr3TjT9/4OzdCjCIhbTU3qP8V5YGeMA/m81IwJN3R+O1vToh+9N886Y im1vH6ysGPjwLWJjrv0Kadm3HbRZwtTs7Da/w9kshGSq9JBNXieNY+vAbha6ZG2Mou9M RBIFr/G3kPR4pKqQO6h3S9lfQaiWXp+VCOaPft8zpOCi4SSQ5jUWl6fNCj4wy4rwHtI6 UXULNo8eD1wI1TBd2r1o+MlijldMj9rj9XbAY/rhIq4CXXDOtrsUHSBDGR1BF7/H7T0m 5grlptxlL4fpbx7FJJNCC96S9AbWbJ3eI2dVnV86Bcmv0rIStWSnQYG9sXXEqtlhVmw+ JECA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=OPCVrxwr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si9712415oia.100.2020.03.24.14.13.38; Tue, 24 Mar 2020 14:14:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=OPCVrxwr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727496AbgCXVNO (ORCPT + 99 others); Tue, 24 Mar 2020 17:13:14 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33770 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbgCXVNO (ORCPT ); Tue, 24 Mar 2020 17:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UBXTlfBB5V6oYxQxCHfMAgYy2LlHqpP4L4e/SUdnMD8=; b=OPCVrxwrDknGD1joDQe03rmnNE 72LgREK3mBMeamsc7gEiKlBNomk45jzZWIQQvLAt0Q9CgvmBBXJPV2yGTF/4LaBMBOk5TRzED7CJS YLCKvhv7P1UQ/Vwy4ostNG3SrRx4QVwIGh1Z5oWVkgLIxscU4+Nbg7SBlMUSs4SLQoSX+0ba14Cxx xNlgAQxuFxcxPj0aFYdgVp5dAFV4i4/4Maca2y0SilePnJyP6acrX+CJoO22MwcFYpTAXHeJwlce1 zyYAlgxGu87puwW0rcbJgZ/xR6/tEb3jEebyW3kqz5CqNZOG0dU//pm7IZ4C/wYP7H1AWRUu5R+0y /tqDdS3A==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGqrC-0005Yd-CA; Tue, 24 Mar 2020 21:13:06 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 35847983502; Tue, 24 Mar 2020 22:13:03 +0100 (CET) Date: Tue, 24 Mar 2020 22:13:03 +0100 From: Peter Zijlstra To: Randy Dunlap Cc: Josh Poimboeuf , Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , andreyknvl@google.com, aryabinin@virtuozzo.com Subject: Re: linux-next: Tree for Mar 20 (objtool warnings) Message-ID: <20200324211303.GQ2452@worktop.programming.kicks-ass.net> References: <20200320201539.3a3a8640@canb.auug.org.au> <20200324164709.ux4riz7v7uy32nlj@treble> <39035493-9d5b-9da3-10d4-0af5d1cdb32a@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39035493-9d5b-9da3-10d4-0af5d1cdb32a@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 10:53:05AM -0700, Randy Dunlap wrote: > >> kernel/kcov.o: warning: objtool: __sanitizer_cov_trace_pc()+0x89: call to __ubsan_handle_load_invalid_value() with UACCESS enabled > >> > > config-r1510 is attached. > and kcov.o is attached. I'm thinking this is because of commit: 0d6958a70483 kcov: collect coverage from interrupts Which has: @@ -1230,6 +1230,9 @@ struct task_struct { + bool kcov_softirq; @@ -145,9 +157,10 @@ static notrace bool check_kcov_mode(enum kcov_mode needed_mode, struct task_stru + if (!in_task() && !(in_serving_softirq() && t->kcov_softirq)) And this __ubsan_handle_load_invalid_value() is verifying a bool is 0,1. Another reason to hate on _Bool I suppose... Let me see what to do about that... :/