Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp5277435ybb; Tue, 24 Mar 2020 14:18:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvvRsS/INmxj5+7edPuQVL1UyZzqSN8RFVjkZYZhm4Iqq9ARjjuuYMLofrAlpUWZeN2Uy1Y X-Received: by 2002:a05:6830:1e17:: with SMTP id s23mr66632otr.228.1585084690323; Tue, 24 Mar 2020 14:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585084690; cv=none; d=google.com; s=arc-20160816; b=uqaZJRTsMZVRvJZZFO9s1YtMtrUVUmChbEVxebpMmjxhpS9DHGGpSkwvVl7FGLq/Xa G3mcFH9S5u/sfPe9h1Y2F3NohdVfCu3wMFPkJJPLGK0sdwKGuyh9nX2cMRY+KOfBEVSi cN7tBlr9LOXQroZc7AjGC5Pe5LMB83+TbB/rAKqRRLlIYXSx3F4CoEKv6CCjSK/VlglE pg6y5Hyr8PeX2oDsDcWocetEDToqdBitIlHpsXQtpePqjDrpHz87NjqyYbAJbbvZclsh 9GfQZlJ9ua/sAYtSL1h+AFEA9qhd0vfKmiZA7NQf5qE0e7U2ERoXL0ixoQt5olsOWVSJ w/4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7w5K20uYBDk5hVpEpM8Ff2vkm/jWQtncYQJqoaKJkLU=; b=tSEaqPBzovO4wUfKvNDIT85lfnspCKxoVnBL+kw5bEH3sBp31sX4QFwQ1kK/BhLdCm t6Db51bK1pkz+Gg46MX2/TSQkVeNe6brkEWSNNEaIkcK6yrgHTg9DDR31Vpy1aFpFnk8 djFlxVWmS1sX4ci2Fm1UlhCxGX0Z3269usYL4xOO5663sOxejsomyS08U59XS7dWByIT yY4TfLmby5S/s6XAKXSLU0loL2NNK4n+nffiSHlCSv+1CQ5ZFPZB5oGzickTdfmEXtzB MZM1gCdu0mEN6JPAzxRxMu56AIBDE5PeuUl/o3GDykre+YdNZUDoO7ACOrTB8IetQv6m tI9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=PemyobeR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l25si5709278otn.206.2020.03.24.14.17.57; Tue, 24 Mar 2020 14:18:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=PemyobeR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727496AbgCXVPi (ORCPT + 99 others); Tue, 24 Mar 2020 17:15:38 -0400 Received: from merlin.infradead.org ([205.233.59.134]:33866 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726673AbgCXVPi (ORCPT ); Tue, 24 Mar 2020 17:15:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7w5K20uYBDk5hVpEpM8Ff2vkm/jWQtncYQJqoaKJkLU=; b=PemyobeRcL6DwoTmdd6YX2ou/D QSdtl6ZdQORTzBCJ1dFvoZUiYrtOB832L+uUxVUI4VG+tLr8zQ49zJcitht2p2yO2K+3bJq/Hifv/ dRwYRIs5oyzvxjY32NGsX+gnW80vwrd5cJFZG+nhwgfp8MXFfChSUue2OxYYCARTW/PT2PHhYnisP lILrAhP2LNMNspE0nWi7ey8RO8BX9tz4DflBZD4SLeblxUVSiewBNLzK4PyOU0da4j1ql0h6l8yJu YZ9u0E5fcZDneB7zKBpIV63lJxdHukjHnZlM1Gk1PXqhffXX7PrrZfG7XL1Jmqzhkue3p706996mR GPaSP9vA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jGqtY-0005cj-TR; Tue, 24 Mar 2020 21:15:33 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 1E081983502; Tue, 24 Mar 2020 22:15:31 +0100 (CET) Date: Tue, 24 Mar 2020 22:15:31 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, x86@kernel.org, mhiramat@kernel.org, mbenes@suse.cz, brgerst@gmail.com Subject: Re: [PATCH v3 17/26] objtool: Re-arrange validate_functions() Message-ID: <20200324211531.GR2452@worktop.programming.kicks-ass.net> References: <20200324153113.098167666@infradead.org> <20200324160924.924304616@infradead.org> <20200324211006.vaocsz2s7xcalr2i@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324211006.vaocsz2s7xcalr2i@treble> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 04:10:06PM -0500, Josh Poimboeuf wrote: > On Tue, Mar 24, 2020 at 04:31:30PM +0100, Peter Zijlstra wrote: > > + if (!func->len) { > > + WARN("%s() is missing an ELF size annotation", > > + func->name); > > wonky indentation Argh, clearly I need to update my .vimrc on that machine. That's the default C indenting per Vim and I'm pretty sure I reflowed that function with =%.