Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp5300625ybb; Tue, 24 Mar 2020 14:48:17 -0700 (PDT) X-Google-Smtp-Source: ADFU+vucXrvYNRdZeXbOYT31isr3IzhoSBRKQm9sLQ0f8hoZWgcNu3N+ZqBmapfNKFIeHkLlSc6Z X-Received: by 2002:a9d:171e:: with SMTP id i30mr115926ota.327.1585086497068; Tue, 24 Mar 2020 14:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585086497; cv=none; d=google.com; s=arc-20160816; b=IqfSY94LUUzshjmIz71hfg53dznfSq1j5n12bOH753DVawFOLpwtGxkiiZdp/I2hUz cOpyuRrnARuomm9c5LTKXOuG7/HxuIOKa6NLmW8YcFxr+b56hBEHRUOC+uMnK0DmpYF2 PT97zfNrKHeHhFnmxKQYTiNx3a8RDARz4kPMS5DIZgeNquvGvGdVRmwqFHBj4cZ3yekM bfJ5oDHFYkKRdqqIo1AnftTI23n5QEqSpDJi4fx/0SOcWLRHXx6OwV0ILWv/MEL4+VRt VREkffiogbfrqxi8tX1I9acejfUXj87quTbCOMUh+00323GRGFhqRS0jTNzm4zjqswk4 +ubg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=W6hLqoDr3yu6uqhKp/rISKPs8GmFm6aK0WFzMuU/Xr4=; b=YtBqTnY5AOWVjueaBwuMrDwHix45cO/6jTdvuXe+AQ+QMmgTFDEZxr3ovi2jpEJ0LX YZRgHqc8/kDzgvf+pUkshSIPP0Pm3pnwDbEtmSDxWYuFynprJN7S16G54U+g/PikVczT LDvh9XKmcSGn4in4wqQ2RvBzDUie3b8b3voTlnmuG/59a3CNgfiooH4Mm0H2mEESNt0N Mr5enMKb9XdTAjtFiO0sPSnE4yQcjsEB3/TrE2vgXACt3WDVFTr9YlaMt7SZYHEDXL+8 mJhSvbx1UkOZbj8epWgKSKYOQuqmyLiqileGFOglqMqNY190EHzH0UcO+Bnr4IbN11Bi 22QQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z29si1068519ood.32.2020.03.24.14.48.03; Tue, 24 Mar 2020 14:48:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727664AbgCXVrh (ORCPT + 99 others); Tue, 24 Mar 2020 17:47:37 -0400 Received: from sauhun.de ([88.99.104.3]:55502 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727023AbgCXVrg (ORCPT ); Tue, 24 Mar 2020 17:47:36 -0400 Received: from localhost (p54B3339A.dip0.t-ipconnect.de [84.179.51.154]) by pokefinder.org (Postfix) with ESMTPSA id AA43C2C08EF; Tue, 24 Mar 2020 22:47:34 +0100 (CET) Date: Tue, 24 Mar 2020 22:47:34 +0100 From: Wolfram Sang To: Kai-Heng Feng Cc: ajayg@nvidia.com, Andy Shevchenko , "open list:I2C CONTROLLER DRIVER FOR NVIDIA GPU" , open list Subject: Re: [PATCH v3] i2c: nvidia-gpu: Handle timeout correctly in gpu_i2c_check_status() Message-ID: <20200324214734.GI7641@ninjato> References: <20200324152812.20231-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="K1SnTjlYS/YgcDEx" Content-Disposition: inline In-Reply-To: <20200324152812.20231-1-kai.heng.feng@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --K1SnTjlYS/YgcDEx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 24, 2020 at 11:28:11PM +0800, Kai-Heng Feng wrote: > Nvidia card may come with a "phantom" UCSI device, and its driver gets > stuck in probe routine, prevents any system PM operations like suspend. >=20 > There's an unaccounted case that the target time can equal to jiffies in > gpu_i2c_check_status(), let's solve that by using readl_poll_timeout() > instead of jiffies comparison functions.=20 >=20 > Fixes: c71bcdcb42a7 ("i2c: add i2c bus driver for NVIDIA GPU") > Suggested-by: Andy Shevchenko > Signed-off-by: Kai-Heng Feng Applied to for-current, thanks! --K1SnTjlYS/YgcDEx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl56f/YACgkQFA3kzBSg KbZ5Xw//cOoQa5Y+68tFpZVVLo4CYZCEFIq6rdbNvDMTfJ1zoRXnGBVVO+E/og2s Rw3H1V2XIPWhBMlHc/2muuYoP+tNC/O0OV5XWqwPxfCpxhgpoJ4G0MB+MwCTYYH/ 80JeHyvzFNJ/2yJ2vBZRABwnuPdytS8JFADcfMTj2zaK0PDjk49b0Bl6jsAPwK97 VDDvK8pfF0Qlr97uuU3W1v3OqPqd08B4iOneHGmSdAYS7igDXyKa0+9xmZcT+u1m r45F94Co72onsdEmHd5YrzX+KBLztJiERIxgFU89WoUdRDtOkAn0YjgBgan76pPy 31qtlnJ8x+iRx8R25SnSHVKKfAWPY6Y1pEDJAQWFNpXszjkIa8vSBtnmHe1y7Fbl YPFI2I0GHYThxo6B55ivOqHcbotei6/VCTrH05GzcL4qtD4LT6Q6EoSDzghEnh2a yrLnnnyQ4Qp2H1ZVx4odW8xrmOLTnnC893jr84tihhDHcYCC6AhxQfmxNq/xiy95 nVyxm4+804cpSill84Za4lquz2DVQaj80KZJkrUiAKFG/yagvWdiHXPL41bfcElG 5+Koioad3cw4dc6Bczdb6WrKIcwjZ4dqKtDOpHtEVaY3AvZFXFi3iQfPXc/YvEC+ AwLMCii1mhUHwSrZ+xK9A0HLsciLjKcYe/jH1XO0MemHKaP/xJo= =gmtZ -----END PGP SIGNATURE----- --K1SnTjlYS/YgcDEx--