Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] nvmem: core: use is_bin_visible for permissions
Thread-Topic: [PATCH 3/3] nvmem: core: use is_bin_visible for permissions
Thread-Index: AQHWAf/vktu3KaBaqESPDuw2qu8YI6hYXUiA
Date:   Tue, 24 Mar 2020 23:05:07 +0000
Message-ID: <PSXP216MB04380BBC9B7488DEC47ACB6A80F10@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
References: <20200324171600.15606-1-srinivas.kandagatla@linaro.org>
 <20200324171600.15606-4-srinivas.kandagatla@linaro.org>
In-Reply-To: <20200324171600.15606-4-srinivas.kandagatla@linaro.org>
Accept-Language: en-AU, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [bsQOyyMCmwJRRSICar1jsaAigu5GB39yeea4vnN6y522H3gx7oRm4cvYxyC9CQYq]
x-microsoft-original-message-id: <20200324230459.GA2372@nicholas-dell-linux>
x-ms-publictraffictype: Email
x-incomingheadercount: 50
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 10ef63d0-f433-4f44-2bd0-08d7d047cb6a
x-ms-traffictypediagnostic: HK2APC01HT138:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 0NhCOWAcPlYcJjtCRpLlILKmVmfePvfjep5OQCuFZLx40+NbH3IU/av7IQ1lArSfOLR5GNALogwX3ul57N+KZMVSomJnhGwL0PhRWJ8YJr1oty9jHyB884AxUgEKvxY1Kl4yn01CgcxyLKSPqylDbhCDJ4LIEfUsfEMBhsz44fxrNGT7KuzVPH8QXAJywh08
x-ms-exchange-antispam-messagedata: PXy851lvXXJkh1bcFI0adP2X5sIEy426EQWh+I1jBO/HsPGJBwmdmPFNyADp+O3/brbu0AgnHR0mNlMbnUcYr7d/Tqfp+aQmk0015O8XfylZAZiSnvXxfI+kGtOXcTPJV2CR4MxjbaGqM/W7bwpHASWzsEqCD+eee4SqMD7lX5/yGXxXS/bgF8V8fsHdod/z7lX4SEdiicWg1JsjunA1kA==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4858EECB40EBC4428222026CFE25EAD5@KORP216.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 10ef63d0-f433-4f44-2bd0-08d7d047cb6a
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Mar 2020 23:05:08.0018
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK2APC01HT138
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 24, 2020 at 05:16:00PM +0000, Srinivas Kandagatla wrote:
> By using is_bin_visible callback to set permissions will remove a large list
> of attribute groups. These group permissions can be dynamically derived in
> the callback.
> 
> Suggested-by: Greg KH <gregkh@linuxfoundation.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
>  drivers/nvmem/nvmem-sysfs.c | 74 +++++++++----------------------------
>  1 file changed, 18 insertions(+), 56 deletions(-)
> 
> diff --git a/drivers/nvmem/nvmem-sysfs.c b/drivers/nvmem/nvmem-sysfs.c
> index 8759c4470012..1ff1801048f6 100644
> --- a/drivers/nvmem/nvmem-sysfs.c
> +++ b/drivers/nvmem/nvmem-sysfs.c
> @@ -103,6 +103,17 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
>  
>  	return count;
>  }
> +static umode_t nvmem_bin_attr_is_visible(struct kobject *kobj,
> +					 struct bin_attribute *attr, int i)
> +{
> +	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct nvmem_device *nvmem = to_nvmem_device(dev);
> +
> +	if (nvmem->root_only)
> +		return nvmem->read_only ? 0400 : 0600;
> +
> +	return nvmem->read_only ? 0444 : 0644;
> +}
Looks like I did a pretty good job as I arrived at a similar result 
independently. Even added root_only to nvmem_device. You beat me to it. 
:)

>  const struct attribute_group **nvmem_sysfs_get_groups(
>  					struct nvmem_device *nvmem,
>  					const struct nvmem_config *config)
>  {
> -	if (config->root_only)
> -		return nvmem->read_only ?
> -			nvmem_ro_root_dev_groups :
> -			nvmem_rw_root_dev_groups;
> -
> -	return nvmem->read_only ? nvmem_ro_dev_groups : nvmem_rw_dev_groups;
> +	return nvmem_dev_groups;
>  }
I was wondering if we can export nvmem_dev_group instead of this 
nvmem_sysfs_get_groups() to fetch it.

Also, we need some logic in nvmem_register() to abort if bad combination 
is given (i.e. root_only set but no reg_read), as returning 0 in 
is_bin_visible callback does not abort. I can do that in my patch if you 
want.

Regards,
Nicholas
>  
>  /*
> -- 
> 2.21.0
>