Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp220057ybb; Tue, 24 Mar 2020 20:49:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvihVbP9hnomhEMHph/UFw2+q1q2y3SwKU8XoVer8fw2D7KGIZz6ezUzxCzwGCytMwJCMC9 X-Received: by 2002:a9d:5906:: with SMTP id t6mr1083900oth.338.1585108181512; Tue, 24 Mar 2020 20:49:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585108181; cv=none; d=google.com; s=arc-20160816; b=qHThEvk+BnEs7aBp5qcz+qerPERGZd8/UE2KF1HiLjNeQJ6dhWxIOqINZnMrK3UQZT C8uuJ5X4rKTcCWZ4Qe2ypbrwpa6XnSn9pPDewEBy/be4rMRGt59GTlRN435ISG+GNHeT bQHJkNd4No/GnTLHOuNtFBsMZaqh4Rpg/zz9QPrSEkei3KbX1HeUgNo9r8Z0RJHwB27Q 6+SvdE26LkbJYCyIW/52a3+OY/tqUupfbben3X9YyZ9GaMG2647QbsYk/t78SdV9Sq9w KL9txQyyYtwEbprX/Zdt5u4nL8jDioA5m03WrsXLjfG/hURUFlrSZfYmALDk71LYB4QR 1k8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=CWdyd6j2r7FGt8O9BrZXJ57QRfz1CXItxfCIuK+HcGQ=; b=s8wtcFebZsnyMkZxMNB1GIpn2DflGhRuKWd1zqWm3g2l9UzCDCAOncf3TMaUxOygFW sgPbjonx5xlVeorxAy7EI1kW/0hGPMKKWmtMvmTjv+2nU2Rjnna0L1M3zeFO7Ip3I4K8 Ad0FTHrZ+u4hw+lFqTyDJrCSp9xUsG5XwpMGXMUwVrT/ZgYXgaz+2YWMLhYgsOltELsv 5eb/p2f2EdDxCuTLNGSjDxZwcU15RQy59uQ0nbAUvPCBpyGBQ0+NEAj1hIvGzwN8Udie 8OnBV0WSsaDvXhjbNbDGxWig1lmlhirdX+2xlAfRah5dLYCoc1rsOlUvpDArH7wpW/nu J8ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="q/LyPn1A"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i4si4671828oii.211.2020.03.24.20.49.27; Tue, 24 Mar 2020 20:49:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="q/LyPn1A"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727281AbgCYDs3 (ORCPT + 99 others); Tue, 24 Mar 2020 23:48:29 -0400 Received: from mail-pj1-f65.google.com ([209.85.216.65]:36943 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727253AbgCYDs3 (ORCPT ); Tue, 24 Mar 2020 23:48:29 -0400 Received: by mail-pj1-f65.google.com with SMTP id o12so463570pjs.2 for ; Tue, 24 Mar 2020 20:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CWdyd6j2r7FGt8O9BrZXJ57QRfz1CXItxfCIuK+HcGQ=; b=q/LyPn1AoWnQFxjXkHL+8Jyn2wCJxi2NRICYkLYc9ppR+AjmgKVExL4QA7TUmZODx8 HIg28z2seGLZE4B+yDZ/zWX8HZo82n7SzoPW+4QT8ZPsvZqN4FvOzxJpiiEsZSVlRFMN 7PrJKFb3ZC/5HNSlcSojWFdcxzA1fAzi60UodxOOu1EwiNub38j47zQ7v6sb6Z8DfNEI wv4wZVSh2v9Q8TTjh/7v6v8RDdipvTklOqiadmpFVUAATd0UilLg/AhHoqeIk3B4JFYL okDUpFtPz+PCuGXcUYDl+74zzrNcj5Y5AKMiFRLD0vDOJ5/fGsOB70msOG2NoHRMbtN2 abZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CWdyd6j2r7FGt8O9BrZXJ57QRfz1CXItxfCIuK+HcGQ=; b=kxUkJ8URoz7Knfng0Tcb82xlURaU4smnWEaCP2Ac6MWfeMxhsjInMV5+JmXrThjsTs lXpxFgJO8M+ujsd+1QSylnROopSO++vJ7IJ7kbUlBFy8Ly49A0WjKOYvygazs/HUQ4hM 222Vm6nz99TBFR/VZ336A9orovD1ccExvW8BSVrK+HXRdRSBIzVqupli5cVtQH9QNqqU ITr57csliPeqm9Ey9UXJmnshRg6hVIZ0sj7UoFalZUeoioQSJy/yU8ogGqJ864TD30UJ yMgIDXNJmhu//eFitF3FWKaYjsKVWad47vGGndjuKReOIZlNd58iLlcYNtk8gdXtmS2d HmoQ== X-Gm-Message-State: ANhLgQ0dURnQz1zJ7CGZvG9I6w1n9LqK3pEVxtDvM6sFRCZSjx/AOuQG BeCIcchN9nkE2OJQ8sfjTQsrfw== X-Received: by 2002:a17:902:7886:: with SMTP id q6mr1281983pll.237.1585108108106; Tue, 24 Mar 2020 20:48:28 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id i17sm38674pfo.103.2020.03.24.20.48.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2020 20:48:27 -0700 (PDT) Subject: Re: [PATCH] io_uring:fix missing 'return' in comment To: Chucheng Luo , Alexander Viro , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kernel@vivo.com References: <20200325033138.21488-1-luochucheng@vivo.com> From: Jens Axboe Message-ID: Date: Tue, 24 Mar 2020 21:48:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200325033138.21488-1-luochucheng@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/24/20 9:31 PM, Chucheng Luo wrote: > the missing 'return' work may make it hard > for other developers to understand it. Thanks, that does read better. Notes for future patches: - You should capitalize the first letter in the commit message, any sentence really. - Commit messages should use 72-74 chars of line width - Add a space after 'io_uring:' and title description I fixed these up and hand applied to for-5.7/io_uring. -- Jens Axboe