Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200324064949.23697-1-zhang.lyra@gmail.com> <20200324112115.GA10018@lakrids.cambridge.arm.com>
 <CAAfSe-u7SjWr7VK37OFrFDfm1o-6VwEoUMLctP61us+iQ1emTw@mail.gmail.com> <20200325070127.GA2960703@kroah.com>
In-Reply-To: <20200325070127.GA2960703@kroah.com>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Wed, 25 Mar 2020 15:40:11 +0800
Message-ID: <CAAfSe-u8B387i5w0eFatGvJFE2c4TqjsAA=9mYvqiknQhBsUuQ@mail.gmail.com>
Subject: Re: [PATCH] tty: serial: make SERIAL_SPRD depends on ARM or ARM64
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Mark Rutland <mark.rutland@arm.com>, Jiri Slaby <jslaby@suse.com>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 25 Mar 2020 at 15:02, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Mar 25, 2020 at 09:37:00AM +0800, Chunyan Zhang wrote:
> > Hi Mark, Greg,
> >
> > Pleas see my answer below.
> >
> > On Tue, 24 Mar 2020 at 19:21, Mark Rutland <mark.rutland@arm.com> wrote:
> > >
> > > On Tue, Mar 24, 2020 at 02:49:49PM +0800, Chunyan Zhang wrote:
> > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > > >
> > > > kbuild-test reported an error:
> > > >
> > > >   config: mips-randconfig-a001-20200321 ...
> > > >   >> drivers/tty/serial/sprd_serial.c:1175: undefined reference
> > > >   to `clk_set_parent'
> > > >
> > > > Because some mips Kconfig-s select CONFIG_HAVE_CLK but not CONFIG_COMMON_CLK,
> > > > so it's probably that clk_set_parent is missed for those configs.
> > > >
> > > > To fix this error, this patch adds dependence on ARM || ARM64
> > > > for SERIAL_SPRD.
> > >
> > > From the above, isn't the real dependency COMMON_CLOCK?
> >
> > Some arch can implement its own clock APIs, for example AR7 [1].
>
> That's fine, then they can not select this option.
>
> > The sprd serial driver is used on ARM and ARM64 platforms only for
> > now, which uses clock functions provided by COMMON_CLK, but it has the
> > possibility of being used on other architecture platforms, that was my
> > thought.
> >
> > I should revise this commit message to:
> > "
> > Because some mips Kconfig-s select CONFIG_HAVE_CLK but not define
> > clk_set_parent which is used by the sprd serial driver.
> > ...
> > "
> >
> > Does it make sense?
>
> The arch is not the issue here, the clock framework is, so properly
> depend on that, not an arbitrary CPU type.

Ok, I will address it.

Thanks,
Chunyan