Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write()
 still returns success
To:     Miquel Raynal <miquel.raynal@bootlin.com>
CC:     <richard@nod.at>, <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        <zhangweimin12@huawei.com>, <wangle6@huawei.com>
References: <1584674111-101462-1-git-send-email-nixiaoming@huawei.com>
 <20200324230620.174db1a7@xps13>
From:   Xiaoming Ni <nixiaoming@huawei.com>
Message-ID: <b37235a2-d949-7f78-770b-4a69d9d7aaaa@huawei.com>
Date:   Wed, 25 Mar 2020 15:53:41 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20200324230620.174db1a7@xps13>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020/3/25 6:06, Miquel Raynal wrote:
> Hi Xiaoming,
> 
> Xiaoming Ni <nixiaoming@huawei.com> wrote on Fri, 20 Mar 2020 11:15:11
> +0800:
> 
>> mtdblock_flush()
>> 	-->write_cached_data()
>> 		--->erase_write()
>> 		     mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>>
>> Because mtdblock_flush() always returns 0,
>> even if write_cached_data() fails and data is not written to the device,
>> syscall_write() still returns success
> 
> I reworded a bit the commit log and also added a ' ' after 'mtd:' in
> the title when applying.
> 
> Thanks,
> Miquèl

Your revised commit log is more accurate and clearer, thanks for your 
correction
Thanks.
Xiaoming Ni