Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Mar 2020 09:20:04 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Benjamin Gaignard <benjamin.gaignard@st.com>,
        dmitry.torokhov@gmail.com, robh+dt@kernel.org,
        mark.rutland@arm.com, lgirdwood@gmail.com, broonie@kernel.org,
        wim@linux-watchdog.org, linux@roeck-us.net, p.paillet@st.com,
        linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v5] dt-bindings: mfd: Convert stpmic1 bindings to
 json-schema
Message-ID: <20200325092004.GF442973@dell>
References: <20200304094220.28156-1-benjamin.gaignard@st.com>
 <20200310211849.GA13562@bogus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200310211849.GA13562@bogus>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 10 Mar 2020, Rob Herring wrote:

> On Wed, 4 Mar 2020 10:42:20 +0100, Benjamin Gaignard wrote:
> > Convert stpmic1 bindings to json-schema.
> > 
> > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > ---
> > version 5:
> > - move $ref regulator.yaml under a patternProperties
> > - move remain fixed strings under properties field
> > 
> > version 4:
> > - move on uppder node $ref: ../regulator/regulator.yaml 
> > - move fixed strings under properties field
> > - remove unneeded () in patternProperties
> > - keep ldo3 separate from other ldo properties
> > Note:
> > - 'st,mask-reset' property stay in each subnode, I don't find
> >   the syntax to avoid dupliquate it. 
> > - ldo6-supply and all possible *-supply are describe by this regular
> >   expression: ^(buck[1-4]|ldo[1-6]|boost|pwr_sw[1-2])-supply$":
> > 
> > version 3:
> > - put $ref under allOf keyword
> > - for each regulator node add the list of supported regulator properties
> > 
> >  .../devicetree/bindings/input/st,stpmic1-onkey.txt |  28 --
> >  .../devicetree/bindings/mfd/st,stpmic1.txt         |  61 ----
> >  .../devicetree/bindings/mfd/st,stpmic1.yaml        | 339 +++++++++++++++++++++
> >  .../bindings/regulator/st,stpmic1-regulator.txt    |  64 ----
> >  .../bindings/watchdog/st,stpmic1-wdt.txt           |  11 -
> >  5 files changed, 339 insertions(+), 164 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt
> >  delete mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt
> >  create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/regulator/st,stpmic1-regulator.txt
> >  delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt
> > 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Can you take this please Rob?

It would save an IB and PR.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog