Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Michael Walle <michael@walle.cc>,
        "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Jiri Slaby <jslaby@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Leonard Crestez <leonard.crestez@nxp.com>
Subject: RE: [EXT] [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value
 checking
Thread-Topic: [EXT] [PATCH v2 2/2] tty: serial: fsl_lpuart: fix return value
 checking
Thread-Index: AQHWAoTG1OM2WzNTEUGCC1E+7uhgbKhZFR3w
Date:   Wed, 25 Mar 2020 10:07:14 +0000
Message-ID: <VI1PR0402MB3600E689FB51FD5D6E2A2911FFCE0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20200325090658.25967-1-michael@walle.cc>
 <20200325090658.25967-2-michael@walle.cc>
In-Reply-To: <20200325090658.25967-2-michael@walle.cc>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 75f919ad-cdf4-4b6a-bf68-08d7d0a44b1c
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2020 10:07:14.8434
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3rRPtjeUYaQPewbDOcy9EWbSh/jF4SLCWcq3x8+7/zrQZibNFsIkag6IWrpWtP6TlukMApSveDVcwK7VJiMt+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3678
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Michael Walle <michael@walle.cc> Sent: Wednesday, March 25, 2020 5:07=
 PM
> The return value of lpuart_dma_tx_request() is an negative errno on failu=
re
> and zero on success.
>=20
> Fixes: 159381df1442f ("tty: serial: fsl_lpuart: fix DMA operation when us=
ing
> IOMMU")
> Reported-by: Leonard Crestez <leonard.crestez@nxp.com>
> Signed-off-by: Michael Walle <michael@walle.cc>

Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> changes since v1:
>  - none
>=20
>  drivers/tty/serial/fsl_lpuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpu=
art.c index
> 131018979b77..5d41075964f2 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1538,7 +1538,7 @@ static void lpuart_tx_dma_startup(struct
> lpuart_port *sport)
>                 goto err;
>=20
>         ret =3D lpuart_dma_tx_request(&sport->port);
> -       if (!ret)
> +       if (ret)
>                 goto err;
>=20
>         init_waitqueue_head(&sport->dma_wait);
> --
> 2.20.1