Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp549568ybb; Wed, 25 Mar 2020 05:11:43 -0700 (PDT) X-Google-Smtp-Source: ADFU+vse5baRgo1SzAD7zScMJM9wdX7T2yGofjZ9QlfMmwY0kcxKHShYJbryIC4j8FuIjC8ANi1j X-Received: by 2002:aca:7285:: with SMTP id p127mr2181770oic.32.1585138303150; Wed, 25 Mar 2020 05:11:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585138303; cv=none; d=google.com; s=arc-20160816; b=rUlL+qzL/pOgCivkc426DG/whxh9F05glBEN5GOQPC9MYA4ZlRXFpLdWaBsqJMtRxk iUU4NTsZUjqUQUaIFXnMeMo2ZWTpYMcXvwwSC/EbRG8viX7vH8k2lQwlB+cyl83ktspK nAHSB/d6Zo0V+mPtykiHLJ7XmaXwpthEj4tfVS/POGcuLojdtKfYe9oP5PsdPRA1Eox0 ++itHKaHgiUZupvBSJr9shZGu8ZnQVGOGns9h2Rf/vzjcVu37c9JuPPTHd1+cdTzYvr0 dHVkZwBDAtVS+1IN+nj5TxqonK/gme6wKJgJapupElwB5TGUIAD5V3OHSd9AddyUUoOX z0Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=2Pe7BbpLvaRMRYK9WT5edUFZ9bK57gxP0kBgfSQY5yQ=; b=Ved2ylgZs/00sg0t7zS5LvdEMzAKYaF0GHlZ3fa4XAJ89rhCA0M2S6eNrHJw1NojC/ KlgMklf2Zxz9lswgpQlzgEIIjqLtkTbsAo0yVNcvqLutsZJCJuxMHCtJbqxq0bBfJjpe tQDpCJULP+GTnVCaScS3/CgMpZY4cCJkWUBjRGynshYvLXUPiv4Q/vh5fKXGGq+yU7+C OqcyazbgmXu8ceYxcN+jrr4VTDj3haZN458NSff8H+DkR8GZAwM/OnzWlsvcEMAiW7b4 1N5D+OzNVRTD7MHOcfobzo3FLhuElWhksp8uCObvoUg+VGiuOi873SH6gBVceBNxA59Q COCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10si10466955oti.165.2020.03.25.05.11.30; Wed, 25 Mar 2020 05:11:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727442AbgCYMKf (ORCPT + 99 others); Wed, 25 Mar 2020 08:10:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:53460 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727253AbgCYMKf (ORCPT ); Wed, 25 Mar 2020 08:10:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4BA19AC44; Wed, 25 Mar 2020 12:10:34 +0000 (UTC) Date: Wed, 25 Mar 2020 13:10:33 +0100 (CET) From: Miroslav Benes To: Peter Zijlstra cc: tglx@linutronix.de, jpoimboe@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org, mhiramat@kernel.org, brgerst@gmail.com Subject: Re: [PATCH v3 14/26] objtool: Optimize read_sections() In-Reply-To: <20200324160924.739153726@infradead.org> Message-ID: References: <20200324153113.098167666@infradead.org> <20200324160924.739153726@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2020, Peter Zijlstra wrote: > Perf showed that __hash_init() is a significant portion of > read_sections(), so instead of doing a per section rela_hash, use an > elf-wide rela_hash. > > Statistics show us there are about 1.1 million relas, so size it > accordingly. > > This reduces the objtool on vmlinux.o runtime to a third, from 15 to 5 > seconds. > > Signed-off-by: Peter Zijlstra (Intel) > Acked-by: Josh Poimboeuf Reviewed-by: Miroslav Benes M