Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp600334ybb; Wed, 25 Mar 2020 06:10:19 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsw0TGsmWdDLuhRuIMXQk+LC5n5+5zJeRwE+kz1lYE5QQyFJDmp5bzPmM0UznrLzKnwyTK/ X-Received: by 2002:a9d:6c19:: with SMTP id f25mr948345otq.371.1585141819134; Wed, 25 Mar 2020 06:10:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585141819; cv=none; d=google.com; s=arc-20160816; b=TA3/EmCyqNdjco24byF+ZHEhettLOL2Q0cJi2nifdMRmF9lZHMD3fMq3PjMHx6osq1 RKOeqpE7daAQ1cPYPb3dS+WB5zf62OZ4Hl/NDZNDV/4NYu9o5aRv5OlrJ22Vy7uOg59R 0tyCwCHR2vm8LalwLm1MrDc4NflOopZtCa8VqQ4+MRdD3smmlPwWD1c3ki32V6F4Q3ER +6QBY4FGaieAOSk6r18GFkkMcW/is9q9vowNlHJy+/paLu5uVMHEJJG6P6YwUxfT6nBl XDA5qWG2jSWbq0LUo7wckTslb+Op95QHSbIVH+VBw/cI2x7c2G6ZEpeLfzI54r2hs/4/ pTFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=MmDSH51e7oidVyu0h0NZyr6OzP7Te9DF1c+cTCaNP/Q=; b=vxHfKBH/M0QPt6ldapV2w3u9NjHcQ6u1xOe5fZudfu6llWUxYvo6Xxu/wOynxtNeyS VEJaL9pFtHjrSNMbNxsvEGI6GDD7ZVzOhg/9op+KNV9Y1ylCL1NAKJss5hA4SeY5LSnm h/P/ooUogclI+CtjYmjPNNldgZxotB9FT3RwlNWyq/0gh5onfRYxh97RLq0Dfbqp0Acp Pt7NUSLg1TcJnKs8UbAvSTFPQfUg6nqSs/WP9vDPqJ+DNNF1zMOp4CCvcNxC7DGwLngl CmX9GEzTESGFRjnvJBZnEIXc4Il21YGXESAQhuvYxGFdRV5QX1vP97O5AwMx2ZGcSAO4 keGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=CLopwyrv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l25si6820674otn.206.2020.03.25.06.10.06; Wed, 25 Mar 2020 06:10:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.ru header.s=default header.b=CLopwyrv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727478AbgCYNHG (ORCPT + 99 others); Wed, 25 Mar 2020 09:07:06 -0400 Received: from forwardcorp1j.mail.yandex.net ([5.45.199.163]:38412 "EHLO forwardcorp1j.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727129AbgCYNHF (ORCPT ); Wed, 25 Mar 2020 09:07:05 -0400 Received: from mxbackcorp1o.mail.yandex.net (mxbackcorp1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::301]) by forwardcorp1j.mail.yandex.net (Yandex) with ESMTP id 1D9C72E15E0; Wed, 25 Mar 2020 16:07:03 +0300 (MSK) Received: from myt4-18a966dbd9be.qloud-c.yandex.net (myt4-18a966dbd9be.qloud-c.yandex.net [2a02:6b8:c00:12ad:0:640:18a9:66db]) by mxbackcorp1o.mail.yandex.net (mxbackcorp/Yandex) with ESMTP id mcZa33whj9-72YaEGHq; Wed, 25 Mar 2020 16:07:03 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1585141623; bh=MmDSH51e7oidVyu0h0NZyr6OzP7Te9DF1c+cTCaNP/Q=; h=Message-ID:Date:To:From:Subject:Cc; b=CLopwyrvQooX+H/lBYtsrKh4IyXX/K3Le0VstZQDxDTkiYJCovjDfeAeeE4eEGjVq vsZbRRuDISQmybsJYFwNjIc+0vFt0/0XMgN0nq8r+9N8Fkd5LhS8WFln3iwsbBL+xL 9de0XUle0711gGZoL2ovn1lU2i22uPKRm/aeXKGk= Authentication-Results: mxbackcorp1o.mail.yandex.net; dkim=pass header.i=@yandex-team.ru Received: from unknown (unknown [2a02:6b8:b080:8204::1:e]) by myt4-18a966dbd9be.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id cFVHxoSefV-72caHIwA; Wed, 25 Mar 2020 16:07:02 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) Subject: [PATCH v4 0/3] block/diskstats: more accurate io_ticks and optimization From: Konstantin Khlebnikov To: linux-block@vger.kernel.org, Jens Axboe , linux-kernel@vger.kernel.org Cc: Mikulas Patocka , Mike Snitzer , Ming Lei Date: Wed, 25 Mar 2020 16:07:01 +0300 Message-ID: <158514148436.7009.1234367408038809210.stgit@buzz> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Simplified estimation for io_ticks introduced in patch https://lore.kernel.org/linux-block/20181206164122.2166-5-snitzer@redhat.com/ could be very inaccurate for request longer than jiffy (i.e. any HDD) There is at least one another report about this: https://lore.kernel.org/linux-block/20200324031942.GA3060@ming.t460p/ See detail in comment for first patch. v1: https://lore.kernel.org/lkml/155413438394.3201.15211440151043943989.stgit@buzz/ v2: https://lore.kernel.org/lkml/158314549775.1788.6529015932237292177.stgit@buzz/ v3: https://lore.kernel.org/lkml/158503038812.1955.7827988255138056389.stgit@buzz/ * update documentation * rebase to current linux-next * fix compilation for CONFIG_SMP=n v4: * rebase to for-5.7/block * make part_stat_read_all static in block/genhd.c --- Konstantin Khlebnikov (3): block/diskstats: more accurate approximation of io_ticks for slow disks block/diskstats: accumulate all per-cpu counters in one pass block/diskstats: replace time_in_queue with sum of request times Documentation/admin-guide/iostats.rst | 5 +- block/bio.c | 9 +-- block/blk-core.c | 5 +- block/genhd.c | 109 +++++++++++++++++++++++---------- include/linux/genhd.h | 6 -- 5 files changed, 88 insertions(+), 46 deletions(-) -- Signature