Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: duqK2d7hXFDy2JKYuurCNNiX1OCz0UhvA9uclN0YQQr8sBU2FJwg8n3wnJfWN4nivLgoQuGDLQ
 DtczPFwfq/xftu08+Cp0Ghgnt3yK72OBJktmFy7+UU701GtxI+LYA32dp8qK2ROPsrMev7HSct
 CBXa6w5nnD3JnWGNjMOKavCgBPS2jOzOkdZtAIp9GwAixXaV8s8Srr7xK69etZsA9XGjqqqIUu
 dZrEYOkQd9oONny08uFbCx1H4nwyt5IysSE29a+W9aCCx7M+ajBZzlxpotpCxweJppVm9bM1xp
 Nr4=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Asutosh Das <asutoshd@codeaurora.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 1/3] scsi: ufshcd: Update the set frequency to devfreq
Thread-Topic: [PATCH v1 1/3] scsi: ufshcd: Update the set frequency to devfreq
Thread-Index: AQHWAjlXIDKoZPLTMUGmc3FvcFDjB6hZKlaQ
Date:   Wed, 25 Mar 2020 13:11:45 +0000
Message-ID: <SN6PR04MB4640BC23D0827886927D302AFCCE0@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <ebd9ea7d0ebb1884b15e4fe7e3e03460c1e3c52b.1585094538.git.asutoshd@codeaurora.org>
In-Reply-To: <ebd9ea7d0ebb1884b15e4fe7e3e03460c1e3c52b.1585094538.git.asutoshd@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f16877a7-6fc2-465f-4796-08d7d0be11a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2020 13:11:45.3984
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iH3cr48bw/3AjRTYRmlnOvx1Z2OqgrpnWTaAuvu4det2N6hw6KOvdCLbszQMkjTIkzP/UV2g+ileKZRgDU9p/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> Currently, the frequency that devfreq provides the
> driver to set always leads the clocks to be scaled up.
> Hence, round the clock-rate to the nearest frequency
> before deciding to scale.
>=20
> Also update the devfreq statistics of current frequency.
>=20
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 2a2a63b..4607bc6 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1187,6 +1187,9 @@ static int ufshcd_devfreq_target(struct device
> *dev,
>         if (!ufshcd_is_clkscaling_supported(hba))
>                 return -EINVAL;
>=20
> +       clki =3D list_first_entry(&hba->clk_list_head, struct ufs_clk_inf=
o, list);
> +       /* Override with the closest supported frequency */
> +       *freq =3D (unsigned long) clk_round_rate(clki->clk, *freq);
>         spin_lock_irqsave(hba->host->host_lock, irq_flags);
Please remind me what the spin lock is protecting here?

>         if (ufshcd_eh_in_progress(hba)) {
>                 spin_unlock_irqrestore(hba->host->host_lock, irq_flags);
> @@ -1201,8 +1204,13 @@ static int ufshcd_devfreq_target(struct device
> *dev,
>                 goto out;
>         }
>=20
> -       clki =3D list_first_entry(&hba->clk_list_head, struct ufs_clk_inf=
o, list);
> +       /* Decide based on the rounded-off frequency and update */
>         scale_up =3D (*freq =3D=3D clki->max_freq) ? true : false;
> +       if (scale_up)
> +               *freq =3D clki->max_freq;
This was already established 2 lines above ?

> +       else
> +               *freq =3D clki->min_freq;
> +       /* Update the frequency */
>         if (!ufshcd_is_devfreq_scaling_required(hba, scale_up)) {
>                 spin_unlock_irqrestore(hba->host->host_lock, irq_flags);
>                 ret =3D 0;
> @@ -1250,6 +1258,8 @@ static int ufshcd_devfreq_get_dev_status(struct
> device *dev,
>         struct ufs_hba *hba =3D dev_get_drvdata(dev);
>         struct ufs_clk_scaling *scaling =3D &hba->clk_scaling;
>         unsigned long flags;
> +       struct list_head *clk_list =3D &hba->clk_list_head;
> +       struct ufs_clk_info *clki;
>=20
>         if (!ufshcd_is_clkscaling_supported(hba))
>                 return -EINVAL;
> @@ -1260,6 +1270,8 @@ static int ufshcd_devfreq_get_dev_status(struct
> device *dev,
>         if (!scaling->window_start_t)
>                 goto start_window;
>=20
> +       clki =3D list_first_entry(clk_list, struct ufs_clk_info, list);
> +       stat->current_frequency =3D clki->curr_freq;
Is this a bug fix?
devfreq_simple_ondemand_func is trying to establish the busy period,
but also uses the frequency in its calculation - which I wasn't able to und=
erstand how.
Can you add a short comment why updating current_frequency is needed?


Thanks,
Avri