Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: ToonmeZMk17zCZcRpZxH9412S9/1bkBDuEdGblxxR8amMi8W3jYWbCngy6Uo5kaJ4XEvFHvYon
 oIkDcuW5G63+e55e8OLgANyPa8Vg3T3zlRiynS5HY9u0eSyQC3cGVkhYzQHdCO3o/gGeHyejy4
 HTsK06ueSaX/E1XlFsZVVKqCUlSbu8e8tO4hjlDUu1kd07QOPGP0DSez1ICT1La/LUMMyL4Bm4
 zKE2SNfi5qJYgSy7iSik1lTUEW+gOQILNdbPq5kR3yjfgzgO2DX0DEJ5VBXhb/JuEKaUz2H5FQ
 AO4=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Asutosh Das <asutoshd@codeaurora.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
CC:     "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Venkat Gopalakrishnan <venkatg@codeaurora.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 2/3] scsi: ufshcd: Let vendor override devfreq
 parameters
Thread-Topic: [PATCH v1 2/3] scsi: ufshcd: Let vendor override devfreq
 parameters
Thread-Index: AQHWAjldPSd/dS3CHkmV7T+0N6HIQKhZJ5xA
Date:   Wed, 25 Mar 2020 13:11:44 +0000
Message-ID: <SN6PR04MB46407C82C61441861C4628D6FCCE0@SN6PR04MB4640.namprd04.prod.outlook.com>
References: <ebd9ea7d0ebb1884b15e4fe7e3e03460c1e3c52b.1585094538.git.asutoshd@codeaurora.org>
 <59a83a2dba7d7f2be4bd4af56267fee8d1c5bb7c.1585094538.git.asutoshd@codeaurora.org>
In-Reply-To: <59a83a2dba7d7f2be4bd4af56267fee8d1c5bb7c.1585094538.git.asutoshd@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e95876f-6dba-415f-c5d0-08d7d0be10f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2020 13:11:44.2061
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mdRTXBGUjH9s6npdxQOxCl7KNbE9eh8g74zl0PavvXwkh8oSvZ6+L+46zL2moc6K/O47D2ENOAboJDDECc0LLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4256
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> Vendor drivers may have a need to update the polling interval
> and thresholds.
> Provide a vops for vendor drivers to use.
>=20
> Signed-off-by: Asutosh Das <asutoshd@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 11 ++++++++++-
>  drivers/scsi/ufs/ufshcd.h | 12 ++++++++++++
>  2 files changed, 22 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 4607bc6..7643ef5 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -1300,6 +1300,13 @@ static struct devfreq_dev_profile
> ufs_devfreq_profile =3D {
>         .get_dev_status =3D ufshcd_devfreq_get_dev_status,
>  };
>=20
> +#if IS_ENABLED(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)
> +static struct devfreq_simple_ondemand_data ufs_ondemand_data;
Might want to set default values here?


>  #include <asm/irq.h>
> @@ -327,6 +328,9 @@ struct ufs_hba_variant_ops {
>         void    (*dbg_register_dump)(struct ufs_hba *hba);
>         int     (*phy_initialization)(struct ufs_hba *);
>         void    (*device_reset)(struct ufs_hba *hba);
> +       void    (*config_scaling_param)(struct ufs_hba *hba,
> +                                       struct devfreq_dev_profile *profi=
le,
This is an excellent idea, because not only it allows you to edit the polli=
ng interval,
But you might want to replace the target and status handlers one day.=20

> +                                       void *data);
>  };


Thanks,
Avri