Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp626073ybb; Wed, 25 Mar 2020 06:37:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vun4RBEy7M7zkUa/pZcAeMhRkKMar0CLVf/bATXLMK1Umq9iDx8sJCafThDyOLzJyFvXPdG X-Received: by 2002:a9d:7698:: with SMTP id j24mr2546167otl.370.1585143475901; Wed, 25 Mar 2020 06:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585143475; cv=none; d=google.com; s=arc-20160816; b=MyOiGadMkLV301o96xsxBGGNRJ5KtiVpOq8Bf959m5PT91rcEyToNWh7HbmuzVIH3g N21kXvwQbqbYAXz8yk4yYDs7drkmqr1oduDRHtcYsyaBQz3qdKVo6B2dTTQ7JifOKlaV kr7TEwhDFbQfxI9KGqe1gtyrlbob7LJ2ryChutGGjRNCLpCl34fjYuo3DwNaRg51Os6O x+NB2I8rGdscy6Blc/mGIA/GANpLojpCff7BRLPOfBGbo3E3dTLlTU1je5zYnYmZhLyt LOWgx4GrXas3E170FFxz3+uD/GfygXejkpbcab+VFXVeeiknZfwVNo+IGIaSQFIOOrHE pmlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=iBxNdl2NfJa7URtm+B1HNk2KEdrDaDOdRlGfsxy1+e4=; b=0i2qt7dUz6ps8F+Pd7W/TMFgugUCwgo9Ze08tXG2kzuYnkG2CeUeMe6I+cqHCdmaaq MPbrlNizBqpPkHlvRROFytPswXfTwwbc/d/U4MlBVzqU4zN+5CLNBm+pz1igtSaZ2g36 PNvnUOakfzZzKEBzetcQE7sfNK4G54G6WMas7x6zr4To4UAuVmd2shw6+JwDpqg37/NM ScXeY3dL/JXV2rr2h94lENyDe29Wd/glc22cjVEonUScDAsMsTzAI1EaZy13Zku3fgyM x//C3twwqvB5dnK2ckA8cI+mpTyDgpWzH0ZnQLd7pkEb2e/pNYXicSFNEko0tY3EgUVg 3MOQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b20si11318411otq.263.2020.03.25.06.37.43; Wed, 25 Mar 2020 06:37:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728088AbgCYNgu (ORCPT + 99 others); Wed, 25 Mar 2020 09:36:50 -0400 Received: from esa3.mentor.iphmx.com ([68.232.137.180]:53281 "EHLO esa3.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727656AbgCYNgt (ORCPT ); Wed, 25 Mar 2020 09:36:49 -0400 IronPort-SDR: BBLp2cZZVJA3Tprc9xsnZHKF40uzrZ5qKXYNOYmlU/rJqJmPvAACKUzzgCl8lHqVZXVLrkkMxQ SkOnky6dLxKEj9Dg7J/8v6cGu41vQzB9bfeV6iaTFuwkYyYqysO6zLq1InYnomRX9r6qnjRM7y d09sUd6oOkpJdn3xpTnBZMgHCa7Ve9uCJx1+GHotG9swvuEXgFWVNFVPqJ/uPDnBnYH4kYzFLl GYF3Rwo9q+WkpRTikJCAnHEJomX1Ijf4uONo3bKirbdp9pWoF4jPsqE4AxTWtpsh9s06az0qsA NLk= X-IronPort-AV: E=Sophos;i="5.72,304,1580803200"; d="scan'208";a="47099827" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 25 Mar 2020 05:36:48 -0800 IronPort-SDR: OG6R1QgU6QCRNZYh6/i9lD0NZki/HC/AUdRIqzmnDjXG3G3h6sDjxQ8Y2kfNj47S9vyhm0cOdR 9Wpf3Uv8gVTjWaaKMbdRLsHsr/fpA71eREV0T6XgsxYrPqkekbm7WwDcLwfmFokRONO3xOfdFe qrifl1QI6TCwZgsP0c1UcRp4V9WxTa3kM4H5gPIn5ejyhKj1JoydcQqzsaaTvuyFXlaZIBo28K j94JUSJOeIK9rVluQMrKXIxxgYHAuB+K6b9hdOF1XByVxjhlO2iz4MOcyI/helCRMu5U1HF2yV lyI= From: Jiada Wang To: , , , , , CC: , , , , Subject: [PATCH v9 47/55] Input: Atmel: improve error handling in mxt_update_cfg() Date: Wed, 25 Mar 2020 06:33:26 -0700 Message-ID: <20200325133334.19346-48-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200325133334.19346-1-jiada_wang@mentor.com> References: <20200325133334.19346-1-jiada_wang@mentor.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 258dcd8a68e5..069a532bd0b2 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2185,7 +2185,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem); -- 2.17.1