Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp651502ybb; Wed, 25 Mar 2020 07:06:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvAMqkNhBuqYXhNXyn8OX2xn0umM7esFP/zIiCCTWGm8wO++qyOBCYVlhpuXFomQE7Imue2 X-Received: by 2002:aca:fc88:: with SMTP id a130mr2435202oii.89.1585145200670; Wed, 25 Mar 2020 07:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585145200; cv=none; d=google.com; s=arc-20160816; b=k3vUvyBHkuDKDiUCtz+zNSU2sWBhzAMyCoYA8klYljwA7LGGCB+xfcVZdKgk7c+9/J LrP3L1trvrQZzkDVm2D72otVTUC3DpMbHqdYWZrPHSk31ufCnPmeRXPscztcMhXQCyHh 9ekZR7H25DijwSKwQmNonzVJ8I2KRQUOgY2Q6aaZ8YZuTlx7aErQWH6EUoW8AfHWjGLt ixB+hsBkHbLfH/LAa1O63eLyDVGEuR4B70rR88W7hdHraNwdpm2MVz2Y6lZFkigpUEiX UmoS7ReGtKU2kI4Eeam65l5H0teW3glc5fLIGBZFCga/W6crG44f0ciy1do3bUNKgfkb ldXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=y7x7pypHmviHsoNDPpDPtGeor7eC4OZO8mBSYTXc3/8=; b=jEVNYl/6GDqcDARyL8fhRgZbeiXXRcmBEZNRN6WZOCeiSTpTHwoM5M2eFSBNys0MAl 7YUH0avQ5FwSWrciXJkT1yK8KUR2v1YWMGyIWqAQSUUpWGudsUpSF6bkWekuylgtdZ9U 8PB87Fcbl/WrxMW5LFyPHPkfquxtLu1dSE/5uxT5xcwfGKYX7NJ06gZ+hJn9gPCyH8Nm JAxsC2MJSppDmG/BZTEP4NmME4gCjTbQsoyw81iq8cMLHTx/n6VUnJ5SZifd8b50GpgY bGZQMxGfSFEyudv1pRydQD8KEFpIo18oZ3Dh8WjFynD7EVaVJbM6l5sDXzjUcC6ghgYH GLRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 103si11658308otv.23.2020.03.25.07.06.01; Wed, 25 Mar 2020 07:06:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727560AbgCYOFL (ORCPT + 99 others); Wed, 25 Mar 2020 10:05:11 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:49024 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgCYOFK (ORCPT ); Wed, 25 Mar 2020 10:05:10 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH6ea-002WJg-If; Wed, 25 Mar 2020 14:05:08 +0000 Date: Wed, 25 Mar 2020 14:05:08 +0000 From: Al Viro To: Qian Cai Cc: Linus Torvalds , linux-fsdevel@vger.kernel.org, LKML Subject: Re: Null-ptr-deref due to "sanitized pathwalk machinery (v4)" Message-ID: <20200325140508.GN23230@ZenIV.linux.org.uk> References: <4CBDE0F3-FB73-43F3-8535-6C75BA004233@lca.pw> <20200324214637.GI23230@ZenIV.linux.org.uk> <20200325021327.GJ23230@ZenIV.linux.org.uk> <5281297D-B66E-4A4C-9B41-D2242F6B7AE7@lca.pw> <20200325040359.GK23230@ZenIV.linux.org.uk> <20200325055830.GL23230@ZenIV.linux.org.uk> <20200325140207.GM23230@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325140207.GM23230@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 02:02:07PM +0000, Al Viro wrote: > > + if (unlikely(error)) > > + return ERR_PTR(error); return error; that is