Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: mmotm 2020-03-23-21-29 uploaded
 (pci/controller/dwc/pcie-tegra194.c)
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        <lorenzo.pieralisi@arm.com>
CC:     <akpm@linux-foundation.org>, <broonie@kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <linux-next@vger.kernel.org>,
        <mhocko@suse.cz>, <mm-commits@vger.kernel.org>,
        <sfr@canb.auug.org.au>, linux-pci <linux-pci@vger.kernel.org>
References: <20200324161851.GA2300@google.com>
From:   Vidya Sagar <vidyas@nvidia.com>
Message-ID: <eb101f02-c893-e16e-0f3f-151aac223205@nvidia.com>
Date:   Wed, 25 Mar 2020 20:43:32 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200324161851.GA2300@google.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/24/2020 9:48 PM, Bjorn Helgaas wrote:
> External email: Use caution opening links or attachments
>=20
>=20
> On Tue, Mar 24, 2020 at 08:16:34AM -0700, Randy Dunlap wrote:
>> On 3/23/20 9:30 PM, akpm@linux-foundation.org wrote:
>>> The mm-of-the-moment snapshot 2020-03-23-21-29 has been uploaded to
>>>
>>>     http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release =
(5.x
>>> or 5.x-rcY).  The series file is in broken-out.tar.gz and is duplicated=
 in
>>> http://ozlabs.org/~akpm/mmotm/series
>>
>>
>> on x86_64:
>>
>> ../drivers/pci/controller/dwc/pcie-tegra194.c: In function =E2=80=98tegr=
a_pcie_dw_parse_dt=E2=80=99:
>> ../drivers/pci/controller/dwc/pcie-tegra194.c:1160:24: error: implicit d=
eclaration of function =E2=80=98devm_gpiod_get=E2=80=99; did you mean =E2=
=80=98devm_phy_get=E2=80=99? [-Werror=3Dimplicit-function-declaration]
>>    pcie->pex_rst_gpiod =3D devm_gpiod_get(pcie->dev, "reset", GPIOD_IN);
>>                          ^~~~~~~~~~~~~~
>>                          devm_phy_get
>=20
> Thanks a lot for the report!
>=20
> This was found on mmotm, but I updated my -next branch with Lorenzo's
> latest pci/endpoint branch (current head 775d9e68f470) and reproduced
> this build failure with the .config you attached.
>=20
> I dropped that branch from my -next branch for now and pushed it.
I found that one header file inclusion is missing.
The following patch fixes it.
Also, I wanted to know how can I catch this locally? i.e. How can I=20
generate the config file attached by Randy locally so that I can get the=20
source ready without these kind of issues?

Bjorn/Lorenzo, would you be able to apply below change in your trees or=20
do I need to send a patch for this?

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c=20
b/drivers/pci/controller/dwc/pcie-tegra194.c
index 97d3f3db1020..eeeca18892c6 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -11,6 +11,7 @@
  #include <linux/debugfs.h>
  #include <linux/delay.h>
  #include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
  #include <linux/interrupt.h>
  #include <linux/iopoll.h>
  #include <linux/kernel.h>


>=20
> Bjorn
>=20