Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200324234848.8299-1-skunberg.kelsey@gmail.com> <20200325071608.GA2978943@kroah.com>
In-Reply-To: <20200325071608.GA2978943@kroah.com>
From:   Kelsey <skunberg.kelsey@gmail.com>
Date:   Wed, 25 Mar 2020 09:23:42 -0600
Message-ID: <CAFVqi1R7gHCAMSKw5SSns0jq0++60vyoao6w_g_proC6dYD2_Q@mail.gmail.com>
Subject: Re: [Linux-kernel-mentees] [PATCH] PCI: sysfs: Change bus_rescan and
 dev_rescan to rescan
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
        rbilovol@cisco.com, Don Dutile <ddutile@redhat.com>,
        Ruslan Bilovol <ruslan.bilovol@gmail.com>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        Bodong Wang <bodong@mellanox.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 25, 2020 at 1:16 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Mar 24, 2020 at 05:48:48PM -0600, Kelsey Skunberg wrote:
> > From: Kelsey Skunberg <kelsey.skunberg@gmail.com>
> >
> > rename device attribute name arguments 'bus_rescan' and 'dev_rescan' to 'rescan'
> > to avoid breaking userspace applications.
> >
> > The attribute argument names were changed in the following commits:
> > 8bdfa145f582 ("PCI: sysfs: Define device attributes with DEVICE_ATTR*()")
> > 4e2b79436e4f ("PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO()")
> >
> > Revert the names used for attributes back to the names used before the above
> > patches were applied. This also requires to change DEVICE_ATTR_WO() to
> > DEVICE_ATTR() and __ATTR().
> >
> > Note when using DEVICE_ATTR() the attribute is automatically named
> > dev_attr_<name>.attr. To avoid duplicated names between attributes, use
> > __ATTR() instead of DEVICE_ATTR() to a assign a custom attribute name for
> > dev_rescan.
> >
> > change bus_rescan_store() to dev_bus_rescan_store() to complete matching the
> > names used before the mentioned patches were applied.
> >
> > Signed-off-by: Kelsey Skunberg <kelsey.skunberg@gmail.com>
>
> You should add:
> Fixes: 8bdfa145f582 ("PCI: sysfs: Define device attributes with DEVICE_ATTR*()")
> Fixes: 4e2b79436e4f ("PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO()")
>
> to this too, and a
>         Cc: stable <stable@vger.kernel.org>
> to the signed-off-by: area so that it gets properly backported.
>
> Other than that minor thing, looks good to me, thanks for fixing it so
> quickly:
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Done! I appreciate the review and help, Greg. :)

link to v2:
https://lore.kernel.org/r/20200325151708.32612-1-skunberg.kelsey@gmail.com

- Kelsey