Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp758973ybb; Wed, 25 Mar 2020 09:03:50 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuQoe5oXl4AIBtW6t0uccN6CLsL0ffexUGHCsBGnVPLmAhoVTUHWyNAzR0G1tbfmkYq3SqN X-Received: by 2002:aca:1809:: with SMTP id h9mr2500003oih.87.1585152230368; Wed, 25 Mar 2020 09:03:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585152230; cv=none; d=google.com; s=arc-20160816; b=0aJ0uQm/DzdGYUTE4+hkayRQslB7LMwBOXjCZAzi9WalLl+iVF9eCDoka2QfLwQrLd ei9Qa/Lmp5AdJsZnZdJTj7ntMRLrj7lNKIETS/aNsOwD85lljG96X/TxXGRNlvSPxcW7 QlzJ1IbBnTprWEQNnIsyLm0yT+f+txOu7JSiY1EHLTXEuf3ABU6VE+lc07an8SMy5ls7 7PB0r4Y2YZc96KNlV6kDNcPL701ekkuicdvhoW6wI26qItVHDYK4OwTS2+PhXmmRUcVt vM9RIQ8vo5gndJzaCULlL7xN3R1DeU+XlL/m5fTPGN94o8H4BdNaLLKas8iL98z7TfMc wTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dmarc-filter :dkim-signature; bh=rwYFjjH34Xzwz6CUSnKamcadAswUj8l1Y6KyM0WRdYs=; b=RGx9gGhNVGWlsv3TNr1+X8ZpKoAaXewMi8SsmGysNvwicnVzfkA6eP+QUCQZXTAuh5 Kw9WVpF8vIdocliBG1knsvu1Dj5u2VSJFrMx6Zpsj4vIrnNVR99HAAXcNM3V6ZLgvMrT sDvoN7nHB0Tz8SxlC9SC879K1ZFqMDUI3G0NyepzppJuG14tRUQs4/HK2rtyNMPTNc0o LwM+xMfO6I/Lfl2ATc4TeKD6IIz89KoF3z2Ufr2Xh2wWCRdT38kBZVtXz7ifRLsFbjpV ktkt0vFUPGAOrsenmhy5XDiMNCh5q2mZlw3AOvpx88NnpA/6q0YGW+nxgFh7XUZLVj3I FO5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=b8htubp3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t11si4806839otp.314.2020.03.25.09.03.28; Wed, 25 Mar 2020 09:03:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=b8htubp3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727904AbgCYQCS (ORCPT + 99 others); Wed, 25 Mar 2020 12:02:18 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:38646 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727838AbgCYQCS (ORCPT ); Wed, 25 Mar 2020 12:02:18 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1585152137; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=rwYFjjH34Xzwz6CUSnKamcadAswUj8l1Y6KyM0WRdYs=; b=b8htubp3FUnTWlnCrMrE1KZ7Q061GMW+3Zaxoc2Jy6ldXRKO+gJ2QU/ZZhFZWuDXfwcw6LCT giG5D4MtW7RovEfEdZgfR2jPcok/IFVAkSMfmwfsgURVOM92QBDl+PcorYyhNfPY3kTUR6Hh T0rqiU39dw6YhYmhluyl6dLkMEk= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e7b8077.7fae400bdc38-smtp-out-n03; Wed, 25 Mar 2020 16:01:59 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9CCEEC433BA; Wed, 25 Mar 2020 16:01:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from [10.226.58.28] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4F3AEC433F2; Wed, 25 Mar 2020 16:01:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4F3AEC433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v3 3/7] bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture To: Manivannan Sadhasivam , gregkh@linuxfoundation.org, davem@davemloft.net Cc: smohanad@codeaurora.org, kvalo@codeaurora.org, bjorn.andersson@linaro.org, hemantk@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200324061050.14845-1-manivannan.sadhasivam@linaro.org> <20200324061050.14845-4-manivannan.sadhasivam@linaro.org> From: Jeffrey Hugo Message-ID: <859d465e-c3eb-ab93-b615-ac5fc937f638@codeaurora.org> Date: Wed, 25 Mar 2020 10:01:56 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200324061050.14845-4-manivannan.sadhasivam@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/24/2020 12:10 AM, Manivannan Sadhasivam wrote: > The bhie field in mhi_cntrl needs to be initialized to proper register > base in order to make mhi_rddm_prepare() to work. Otherwise, > mhi_rddm_prepare() will cause NULL pointer dereference. > > Fixes: 6fdfdd27328c ("bus: mhi: core: Add support for downloading RDDM image during panic") > Reported-by: Hemant Kumar > Signed-off-by: Manivannan Sadhasivam Reviewed-by: Jeffrey Hugo -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.