Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200304094220.28156-1-benjamin.gaignard@st.com>
 <20200310211849.GA13562@bogus> <20200325092004.GF442973@dell>
In-Reply-To: <20200325092004.GF442973@dell>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 25 Mar 2020 10:13:54 -0600
Message-ID: <CAL_JsqLW-5=T0p85M9ZurywdNj_nFwj0VJyxHSJGrdzZGkQcJQ@mail.gmail.com>
Subject: Re: [PATCH v5] dt-bindings: mfd: Convert stpmic1 bindings to json-schema
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Benjamin Gaignard <benjamin.gaignard@st.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Pascal PAILLET-LME <p.paillet@st.com>,
        Linux Input <linux-input@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 25, 2020 at 3:19 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 10 Mar 2020, Rob Herring wrote:
>
> > On Wed, 4 Mar 2020 10:42:20 +0100, Benjamin Gaignard wrote:
> > > Convert stpmic1 bindings to json-schema.
> > >
> > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> > > ---
> > > version 5:
> > > - move $ref regulator.yaml under a patternProperties
> > > - move remain fixed strings under properties field
> > >
> > > version 4:
> > > - move on uppder node $ref: ../regulator/regulator.yaml
> > > - move fixed strings under properties field
> > > - remove unneeded () in patternProperties
> > > - keep ldo3 separate from other ldo properties
> > > Note:
> > > - 'st,mask-reset' property stay in each subnode, I don't find
> > >   the syntax to avoid dupliquate it.
> > > - ldo6-supply and all possible *-supply are describe by this regular
> > >   expression: ^(buck[1-4]|ldo[1-6]|boost|pwr_sw[1-2])-supply$":
> > >
> > > version 3:
> > > - put $ref under allOf keyword
> > > - for each regulator node add the list of supported regulator properties
> > >
> > >  .../devicetree/bindings/input/st,stpmic1-onkey.txt |  28 --
> > >  .../devicetree/bindings/mfd/st,stpmic1.txt         |  61 ----
> > >  .../devicetree/bindings/mfd/st,stpmic1.yaml        | 339 +++++++++++++++++++++
> > >  .../bindings/regulator/st,stpmic1-regulator.txt    |  64 ----
> > >  .../bindings/watchdog/st,stpmic1-wdt.txt           |  11 -
> > >  5 files changed, 339 insertions(+), 164 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/input/st,stpmic1-onkey.txt
> > >  delete mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.txt
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/regulator/st,stpmic1-regulator.txt
> > >  delete mode 100644 Documentation/devicetree/bindings/watchdog/st,stpmic1-wdt.txt
> > >
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> Can you take this please Rob?

Yes, done.

Rob