Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp831861ybb; Wed, 25 Mar 2020 10:25:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuwtFMqEc3XUdSekXZDru8HVMv0WyqMzpo1+8FD8t8czEzyo0RR72yFObXamiTWGUE9EC2i X-Received: by 2002:a9d:53cc:: with SMTP id i12mr3342484oth.85.1585157113857; Wed, 25 Mar 2020 10:25:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585157113; cv=none; d=google.com; s=arc-20160816; b=q2gHavN8tHtzN86Q7ZpC9lE43GtKk5um8OjBIKOCE6l80GTiAzPtzFe8pA0ScQZVrn MJUKLwhThqt6aCV6Q3JQxc3yGMVslu04/KMFjz5sTaj4Z56zWl5dQHhNHJafHpiOLgYN lv48Z1GmmD6TxH/mv2md4dZTEUQilRQ146azKbvlaugmqd73eeKm+5h4T25lHl42RZcr BNDYY1SWNCJgIpKaSs5CSIujEaQqRLvkPXvZ9277qRMEMhPrK8s2qSqsK0LQJZyC8Ee4 kRWYL41Hov0OSYjqCCUXkBkLpsKXkJNnX0d396T0EXZPEyn3KGYdm79WBqwj302/4UWT aAiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=BVLD2DnNfc3hv/pKnHW3xvm86ovl8foR84Cu3jjRluI=; b=QjyCHcbFDItixMJPYzqlk8xYtU77DOMWNj1bSwbXw6xUUbYhj8LkbJiAuRQnBeydzq DGDNzJGtkihhCraNl5dmghQE4/MJWfl1V9HFXxJ/Dv5w/Uy4D+Spvuwqf0feHmjILy3k 73QbD2uFWH5+jHsNYc2CJoDPrBJJE/fSoQOVQl6htTlRHI5nQ76oYJ7CNmMKaeE40OAF mqB3sJXJNeTNby1vO06ISMdjhFjrjQ7d15bpEUjlorTwgOoVuO3f5XgHZMvavHcefEaq VltLUS/UBccL4skuhQiK8NYoIIexfVqFsbhximzfgS9PiN6lKh3uJfSYG70iX3X5LygN 4IaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=SsLqtwNs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f46si3457160otf.146.2020.03.25.10.25.00; Wed, 25 Mar 2020 10:25:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=SsLqtwNs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727561AbgCYRYh (ORCPT + 99 others); Wed, 25 Mar 2020 13:24:37 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:55392 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727320AbgCYRYg (ORCPT ); Wed, 25 Mar 2020 13:24:36 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PHIUu9063725; Wed, 25 Mar 2020 17:23:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2020-01-29; bh=BVLD2DnNfc3hv/pKnHW3xvm86ovl8foR84Cu3jjRluI=; b=SsLqtwNsiMxQfXKTjwpsTimV5kVfZurxza6rlE6nubcGWAuwfTQLsLzfoqG0Stq9ih08 JPc3GVkauUN9Cml8EKZvjx69mZwbc+VFBo0XITYoEyIu99jyzN2TJm/F2sx57xWqNmOh zf792px6wXY0CY6mrHRCF2ct3trMMgap/0VufstShpXG/ZafG3BTY0QKhfGEra51fy1s bVcRlQFVCNRwWWIGQ8CXRaRPqg/kGM6NAgfMca09okEe2kHd280CipW0AqoOSFCv+deO 6GesVjacIeNC6T/w8+zLlG+Fz5PlAFNc1I53QbM4qMrLiNxiF65nF5uiIX0kBdvOmngY gQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 3005kva3e8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 17:23:45 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02PHMVh7021581; Wed, 25 Mar 2020 17:23:44 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 2yxw4rvfvw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Mar 2020 17:23:44 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02PHNepp026829; Wed, 25 Mar 2020 17:23:40 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Mar 2020 10:23:40 -0700 To: Christoph Hellwig Cc: "Darrick J. Wong" , "Martin K. Petersen" , Kirill Tkhai , axboe@kernel.dk, bob.liu@oracle.com, agk@redhat.com, snitzer@redhat.com, dm-devel@redhat.com, song@kernel.org, tytso@mit.edu, adilger.kernel@dilger.ca, Chaitanya.Kulkarni@wdc.com, ming.lei@redhat.com, osandov@fb.com, jthumshirn@suse.de, minwoo.im.dev@gmail.com, damien.lemoal@wdc.com, andrea.parri@amarulasolutions.com, hare@suse.com, tj@kernel.org, ajay.joshi@wdc.com, sagi@grimberg.me, dsterba@suse.com, bvanassche@acm.org, dhowells@redhat.com, asml.silence@gmail.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 0/6] block: Introduce REQ_ALLOCATE flag for REQ_OP_WRITE_ZEROES From: "Martin K. Petersen" Organization: Oracle Corporation References: <158157930219.111879.12072477040351921368.stgit@localhost.localdomain> <69c0b8a4-656f-98c4-eb55-2fd1184f5fc9@virtuozzo.com> <67d63190-c16f-cd26-6b67-641c8943dc3d@virtuozzo.com> <20200319102819.GA26418@infradead.org> <20200325162656.GJ29351@magnolia> <20200325163223.GA27156@infradead.org> Date: Wed, 25 Mar 2020 13:23:33 -0400 In-Reply-To: <20200325163223.GA27156@infradead.org> (Christoph Hellwig's message of "Wed, 25 Mar 2020 09:32:23 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9571 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=786 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250140 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9571 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 adultscore=0 priorityscore=1501 mlxlogscore=841 lowpriorityscore=0 mlxscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003250139 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > I am very much against that for the following reason: > > - the current REQ_OP_DISCARD is purely a hint, and implementations can > (and do) choose to ignore it > > - REQ_OP_WRITE_ZEROES is an actual data integrity operation with > everything that entails If you want to keep emphasis on the "integrity operation" instead of the provisioning aspect, would you expect REQ_ALLOCATE (which may or may not zero blocks) to be considered a deterministic operation or a non-deterministic one? Should this depend on whether the device guarantees zeroing when provisioning blocks or not? -- Martin K. Petersen Oracle Linux Engineering