Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v9 13/55] Input: atmel_mxt_ts - add regulator control
 support
To:     Jiada Wang <jiada_wang@mentor.com>, nick@shmanahar.org,
        dmitry.torokhov@gmail.com, jikos@kernel.org,
        benjamin.tissoires@redhat.com, bsz@semihalf.com,
        rydberg@bitmath.org
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        erosca@de.adit-jv.com, Andrew_Gabbasov@mentor.com
References: <20200325133334.19346-1-jiada_wang@mentor.com>
 <20200325133334.19346-14-jiada_wang@mentor.com>
From:   Dmitry Osipenko <digetx@gmail.com>
Message-ID: <672615bc-adce-213f-9e44-864163c0a770@gmail.com>
Date:   Wed, 25 Mar 2020 22:05:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200325133334.19346-14-jiada_wang@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

25.03.2020 16:32, Jiada Wang пишет:
> From: Nick Dyer <nick.dyer@itdev.co.uk>
> 
> Allow the driver to optionally manage enabling/disable power to the touch
> controller itself. If the regulators are not present then use the deep
> sleep power mode instead.
> 
> For a correct power on sequence, it is required that we have control over
> the RESET line.

...
> +	data->reg_vdd = devm_regulator_get(dev, "vdd");
> +	if (IS_ERR(data->reg_vdd)) {
> +		error = PTR_ERR(data->reg_vdd);
> +		dev_err(dev, "Error %d getting vdd regulator\n", error);
> +		goto fail;
> +	}
> +
> +	data->reg_avdd = devm_regulator_get(dev, "avdd");
> +	if (IS_ERR(data->reg_avdd)) {
> +		error = PTR_ERR(data->reg_avdd);
> +		dev_err(dev, "Error %d getting avdd regulator\n", error);
> +		goto fail_release;
> +	}

Hello Jiada,

The new regulator properties should be documented in the device-tree
binding.