Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200324094506.55938-1-alexandru.tachici@analog.com> <20200324094506.55938-3-alexandru.tachici@analog.com>
In-Reply-To: <20200324094506.55938-3-alexandru.tachici@analog.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 25 Mar 2020 13:05:35 -0600
Message-ID: <CAL_JsqKFdcACQtXd5h=4Pxbij+=uoHr2rLTFZMq4fVX8ph398g@mail.gmail.com>
Subject: Re: [RESEND PATCH 2/2] dt-bindings: iio: dac: AD5570R fix bindings errors
To:     Alexandru Tachici <alexandru.tachici@analog.com>
Cc:     "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 24, 2020 at 3:45 AM <alexandru.tachici@analog.com> wrote:
>
> From: Alexandru Tachici <alexandru.tachici@analog.com>
>
> Replaced num property with reg property, fixed errors
> reported by dt-binding-check.
>
> Fixes: ea52c21268e6 ("iio: dac: ad5770r: Add AD5770R support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
> ---
>  .../bindings/iio/dac/adi,ad5770r.yaml         | 77 ++++++++++---------
>  1 file changed, 40 insertions(+), 37 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
> index d9c25cf4b92f..d1755dbc1a41 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5770r.yaml
> @@ -2,7 +2,7 @@
>  # Copyright 2020 Analog Devices Inc.
>  %YAML 1.2
>  ---
> -$id: http://devicetree.org/schemas/bindings/iio/dac/adi,ad5770r.yaml#
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5770r.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>
>  title: Analog Devices AD5770R DAC device driver
> @@ -49,83 +49,84 @@ properties:
>        asserted during driver probe.
>      maxItems: 1
>
> -  channel0:
> +  channel@0:
>      description: Represents an external channel which are
>        connected to the DAC. Channel 0 can act both as a current
>        source and sink.
>      type: object
>
>      properties:
> -      num:
> +      reg:
>          description: This represents the channel number.
> -        items:
> -          const: 0
>
>        adi,range-microamp:
>            description: Output range of the channel.
>            oneOf:
> -            - $ref: /schemas/types.yaml#/definitions/int32-array
>              - items:
> -                - enum: [0 300000]
> -                - enum: [-60000 0]
> -                - enum: [-60000 300000]
> +                - const: 0
> +                - const: 300000
> +            - items:
> +                - const: -60000
> +                - const: 0
> +            - items:
> +                - const: -60000
> +                - const: 300000
>
> -  channel1:
> +  channel@1:
>      description: Represents an external channel which are
>        connected to the DAC.
>      type: object
>
>      properties:
> -      num:
> +      reg:
>          description: This represents the channel number.
> -        items:
> -          const: 1

This should be:

reg:
  const: 1

>
>        adi,range-microamp:
>            description: Output range of the channel.
>            oneOf:
> -            - $ref: /schemas/types.yaml#/definitions/uint32-array
>              - items:
> -                - enum: [0 140000]
> -                - enum: [0 250000]
> +                - const: 0
> +                - const: 140000
> +            - items:
> +                - const: 0
> +                - const: 250000
>
> -  channel2:
> +  channel@2:
>      description: Represents an external channel which are
>        connected to the DAC.
>      type: object
>
>      properties:
> -      num:
> +      reg:
>          description: This represents the channel number.
> -        items:
> -          const: 2
>
>        adi,range-microamp:
>            description: Output range of the channel.
>            oneOf:
> -            - $ref: /schemas/types.yaml#/definitions/uint32-array
>              - items:
> -                - enum: [0 140000]
> -                - enum: [0 250000]
> +                - const: 0
> +                - const: 55000
> +            - items:
> +                - const: 0
> +                - const: 150000
>
>  patternProperties:
>    "^channel@([3-5])$":
>      type: object
>      description: Represents the external channels which are connected to the DAC.
>      properties:
> -      num:
> +      reg:
>          description: This represents the channel number.
> -        items:
> -          minimum: 3
> -          maximum: 5

reg:
  minimum: 3
  maximum: 5

>
>        adi,range-microamp:
>            description: Output range of the channel.
>            oneOf:
> -            - $ref: /schemas/types.yaml#/definitions/uint32-array
>              - items:
> -                - enum: [0 45000]
> -                - enum: [0 100000]
> +                - const: 0
> +                - const: 45000
> +            - items:
> +                - const: 0
> +                - const: 100000

This can be simplified to:

items:
  - const: 0
  - enum: [ 45000, 100000 ]

>
>  required:
>  - reg
> @@ -150,34 +151,36 @@ examples:
>                          vref-supply = <&vref>;
>                          adi,external-resistor;
>                          reset-gpios = <&gpio 22 0>;
> +                        #address-cells = <1>;
> +                        #size-cells = <0>;
>
>                          channel@0 {
> -                                num = <0>;
> -                                adi,range-microamp = <(-60000) 300000>;
> +                                reg = <0>;
> +                                adi,range-microamp = <0 300000>;
>                          };
>
>                          channel@1 {
> -                                num = <1>;
> +                                reg = <1>;
>                                  adi,range-microamp = <0 140000>;
>                          };
>
>                          channel@2 {
> -                                num = <2>;
> +                                reg = <2>;
>                                  adi,range-microamp = <0 55000>;
>                          };
>
>                          channel@3 {
> -                                num = <3>;
> +                                reg = <3>;
>                                  adi,range-microamp = <0 45000>;
>                          };
>
>                          channel@4 {
> -                                num = <4>;
> +                                reg = <4>;
>                                  adi,range-microamp = <0 45000>;
>                          };
>
>                          channel@5 {
> -                                num = <5>;
> +                                reg = <5>;
>                                  adi,range-microamp = <0 45000>;
>                          };
>                  };
> --
> 2.20.1
>