Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Mar 2020 22:03:52 +0000 (GMT)
From:   Alan Maguire <alan.maguire@oracle.com>
To:     shuah <shuah@kernel.org>
cc:     Alan Maguire <alan.maguire@oracle.com>, brendanhiggins@google.com,
        frowand.list@gmail.com, gregkh@linuxfoundation.org, corbet@lwn.net,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH v7 kunit-next 3/4] kunit: subtests should be indented 4
 spaces according to TAP
In-Reply-To: <dd82e9cb-6c88-58cf-933e-f2a644e09b15@kernel.org>
Message-ID: <alpine.LRH.2.21.2003252202360.25268@localhost>
References: <1584110682-3837-1-git-send-email-alan.maguire@oracle.com> <1584110682-3837-4-git-send-email-alan.maguire@oracle.com> <dd82e9cb-6c88-58cf-933e-f2a644e09b15@kernel.org>
User-Agent: Alpine 2.21 (LRH 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 25 Mar 2020, shuah wrote:

> On 3/13/20 8:44 AM, Alan Maguire wrote:
> > Introduce KUNIT_INDENT macro which corresponds to 4-space indentation,
> > and use it to modify indentation from tab to 4 spaces.
> > 
> > Suggested-by: Frank Rowand <frowand.list@gmail.com>
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > Reviewed-by: Frank Rowand <frank.rowand@sony.com>
> > ---
> >   include/kunit/test.h                |  7 +++-
> >   lib/kunit/assert.c                  | 79
> >   +++++++++++++++++++------------------
> >   lib/kunit/test.c                    |  6 +--
> >   tools/testing/kunit/kunit_parser.py | 10 ++---
> >   4 files changed, 54 insertions(+), 48 deletions(-)
> > 
> > diff --git a/include/kunit/test.h b/include/kunit/test.h
> > index f7b2ed4c..d49cdb4 100644
> > --- a/include/kunit/test.h
> > +++ b/include/kunit/test.h
> > @@ -84,6 +84,10 @@ struct kunit_resource {
> >   /* Size of log associated with test. */
> >   #define KUNIT_LOG_SIZE	512
> >   
> > +/* TAP specifies subtest indentation of 4 spaces. */
> > +#define KUNIT_INDENT	"    "
> > +#define KUNIT_INDENT2	KUNIT_INDENT KUNIT_INDENT
> 
> Sorry for a late comment on this.
> 
> What's the reason to do it this way? Why wouldn't you define
> it as 8 spaces long string?
>

I could have I suppose; I thought it makes it a bit easier
to read as above (though it did generate a checkpatch
warning; I thought readability was more important in this   
case, but I can alter if needed).
 
> Also can you please make sure to run checkpatch --strict on the
> patches you send?
>

Sure! There were also some other line-too-long warnings
generated as a result of this patch, but when I fixed those
checkpatch complained about splitting strings across multiple
lines.  The only way out was to reduce the amount of information
in the log messages, which I didn't want to do.  In future I can
note checkpatch warnings that I couldn't find a way to fix in the
commit message if that would help?

Thanks for taking a look!

Alan
 
> thanks,
> -- Shuah
> 
>