Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1068066ybb; Wed, 25 Mar 2020 15:09:30 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtcbWJDGDRN15Xb4qnV4Qw5CudYNJy+hilsmYcBNs8UMD3lmMln++vldPucFTzXkUfdcdpR X-Received: by 2002:aca:ebc5:: with SMTP id j188mr4209271oih.65.1585174170388; Wed, 25 Mar 2020 15:09:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585174170; cv=none; d=google.com; s=arc-20160816; b=kTBpIBrhKS4hDZlG36cvNv+tZI2EkistqWGHFA+0E1bxmAJUof3zofpiAZX6uepW5x AzOKoZhuC7qMupaxtJpjStVWv5D7xMI3J8ng2eI+mA5QuJXQwXqz3sXa3StxaW8N5881 1g9DLjgUCv0DwvvtuHavK5hTLg96QYeWyUhjHoUdDnNpQIIggpAVGeDpJw9+cH9F4xll R2UB1pVKID9Doys1sFN7Ehf/h5nkB5zaXLvOo9lVjq8aUlDPn9unB1pqIY8T+QB1Ao5H gHWIGCVz1dO2zabjxOi2TB0HQ6H/vvTnc9sdYsRrFfVP4l8wNf2HNh3o3iD7z2rIBG7M dugw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9H85Fbzz9EQLFGoIwA8obSz5D1akVHxS7bxFmX8HdbU=; b=Lsa/9Ne1aBHlpeBX/GSQ5T0G4Y9N27Sx6JgN3cImMRCnwBdj4AGSKiFx5wUPkLRryK q03XVXlmYMGAieHhWezerIKejFbfKh+N5xeOthdgG20w5Lf2h14hv6It2dOqsjf1vJ7x dKB+2L5vupChDRgbciog/Flsey0hxAmAk6xgturCgTlUoe9DSGuJZ8+l4n/mCCkXeT1T +2WwRMS9g9ekxOliqBDP5pP1rXcYvxMFKpwUnlmkdaRUL8/42mTIAbeaZrleIZpN94Uk SNyeWyW/fZpHm94/VKjuP4NelqDkNOAB/8vXH6cubR4MthQEMHFL85syistLleg8xyzs rgVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z78si145658oia.200.2020.03.25.15.09.18; Wed, 25 Mar 2020 15:09:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727553AbgCYWHx (ORCPT + 99 others); Wed, 25 Mar 2020 18:07:53 -0400 Received: from foss.arm.com ([217.140.110.172]:53740 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727357AbgCYWHw (ORCPT ); Wed, 25 Mar 2020 18:07:52 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F6641FB; Wed, 25 Mar 2020 15:07:51 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EE6623F71E; Wed, 25 Mar 2020 15:07:50 -0700 (PDT) Date: Wed, 25 Mar 2020 22:07:49 +0000 From: Mark Brown To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski , Bjorn Andersson , Brian Masney , Daniel Lezcano , "David S. Miller" , Guillaume La Roque , Hartmut Knaack , Jonathan Cameron , Kevin Hilman , Lars-Peter Clausen , Lee Jones , Liam Girdwood , Linus Walleij , Masahiro Yamada , Mauro Carvalho Chehab , Michael Hennerich , Neil Armstrong , Peter Meerwald-Stadler , Stephen Boyd , Thomas Gleixner , Zhang Rui , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-media@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' Message-ID: <20200325220749.GF12169@sirena.org.uk> References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sDKAb4OeUBrWWL6P" Content-Disposition: inline In-Reply-To: <20200325220542.19189-5-robh@kernel.org> X-Cookie: Do not stamp. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sDKAb4OeUBrWWL6P Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 25, 2020 at 04:05:41PM -0600, Rob Herring wrote: > Setting 'additionalProperties: false' is frequently omitted, but is > important in order to check that there aren't extra undocumented > properties in a binding. >=20 > Ideally, we'd just add this automatically and make this the default, but > there's some cases where it doesn't work. For example, if a common > schema is referenced, then properties in the common schema aren't part > of what's considered for 'additionalProperties'. Also, sometimes there > are bus specific properties such as 'spi-max-frequency' that go into > bus child nodes, but aren't defined in the child node's schema. Acked-by: Mark Brown --sDKAb4OeUBrWWL6P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl571jQACgkQJNaLcl1U h9Afjwf/TlVFnvMm+meLOwlfTMDT7xvKv6i3g4S/t/OkkG/qfuDfUpRz0LarRYTg 8163ZrHY0aAQmLzyxMQR2cBhzM1tfANuY93djQNhe1ac6MUdNxTGLm1n+m9xh/o8 IsSrgrnEqXCNCgqkAvPcDY7qkeLi68p5VqJIfdOjjeJkusQL3Q0kQUv7kpi6cgXn 5Y+PlKm4cxLmOxFeUmCLQKocDSMttTCjxA/jm7jX+CWzKJjObhgsoHP9rg+uIO+1 VHCHKXwxl1a8dhfG9ZnUxXY9UqGqGINojiPmRtTBX5oZqY95zShlcNiJ2HNaRRsT oIsZgkZuypvPpKies+jaVF2IuoSbcA== =EzfV -----END PGP SIGNATURE----- --sDKAb4OeUBrWWL6P--