Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1116652ybb; Wed, 25 Mar 2020 16:14:28 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs1d3i4zqZ2j9V72+3NRwVPUq2l/qDrBPOtv2ML75HCxB1hP6dNwY4AF1BWgSdvheXsbz1g X-Received: by 2002:aca:4243:: with SMTP id p64mr4334631oia.21.1585178068214; Wed, 25 Mar 2020 16:14:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585178068; cv=none; d=google.com; s=arc-20160816; b=QerVnpsvPn5OPaAm2gaU1ifj5xye3tMk5uNIAHfX/I8rHzvopftMyS9DbKquP8lsIe wCNfNzsZR3H8Oks3Ctd9TBt9Vo9VC8xUiqwGZbimszE2YHtFGil0Y3+6DsuOMrN2V7Yf BHM+QBbrx6BqOWPtshd+HcL8b0YTKXKNpshIvK4wXEXX3InZ2A4GwwLwO8GJoP6z+nl6 cWRh9976c3UcuUEGDGVY3wTeyuk5oqN8OzdHRkp3xIePzvNaNFkDTQwTXqgnbdjKj/7w f8oeNs/bGzH8wRu9vGtXrs1YAJK14kuBihDhd/PHSHHo6pPOZ8LaJ5WN07BJTe74U+xC HwZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mgBkeRcEpFbOp9WcKLqrLxZM4VgI2ISaM3vJlsR4D0c=; b=gOLLifoXIHEgcHxXFhNzwv2cOJ5cU1g10AhgsrmFuySkUAEhQsy21HR4nq8+WmfZZz nb+Etf8iFAZMKnxGrv+91bC3Nanj+XaRCDa3y6gtPQaxivjgOAheIS1oh7rIFA4ZFb1h bpZYI4FZ6Nz3aoXDGSnun0ThWvkG1POxV4vxO51WvjIACZoMlqlAKWQhMjDboGk0Y+z8 FiQ7yottzBzCknSQOyA7YZlJeO+zcsoohr6tejDiMu9CVSC+sUiOjFEt1MvWpIkf56Bg Sb79ZB8+nytHzQ3g02nj2V5n31bEsCeqrUDHBSxQSP1YD2xH5ccv77a/vi42TcAeUw6C P68A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y65si231437oie.92.2020.03.25.16.14.16; Wed, 25 Mar 2020 16:14:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727639AbgCYXN6 (ORCPT + 99 others); Wed, 25 Mar 2020 19:13:58 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:34496 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727395AbgCYXN5 (ORCPT ); Wed, 25 Mar 2020 19:13:57 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1jHFDa-00053N-5c; Thu, 26 Mar 2020 00:13:51 +0100 Date: Thu, 26 Mar 2020 00:13:50 +0100 From: Florian Westphal To: Qian Cai Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter/nf_tables: silence a RCU-list warning Message-ID: <20200325231350.GC878@breakpoint.cc> References: <20200325143142.6955-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325143142.6955-1-cai@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Qian Cai wrote: > It is safe to traverse &net->nft.tables with &net->nft.commit_mutex > held using list_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false > positive, [..] > - list_for_each_entry_rcu(table, &net->nft.tables, list) { > + list_for_each_entry_rcu(table, &net->nft.tables, list, > + lockdep_is_held(&net->nft.commit_mutex)) { Thanks for the patch. Acked-by: Florian Westphal