Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 25 Mar 2020 22:06:02 -0300
User-Agent: K-9 Mail for Android
In-Reply-To: <CAGn10uXpBUnSx8fsL79oMzX5bRLyhqckvxXTLg5JxDARsjFpDw@mail.gmail.com>
References: <1581618066-187262-1-git-send-email-zhe.he@windriver.com> <20200216222148.GA161771@krava> <8cc46abf-208d-4aa4-8d0d-4922106bee6e@windriver.com> <20200325133012.GC14102@kernel.org> <CAGn10uVQdP32PNqyBm_dCxvRisj5tw4GU1f8j6Rq=Q6bmjmaAw@mail.gmail.com> <20200325192640.GI14102@kernel.org> <CAGn10uXpBUnSx8fsL79oMzX5bRLyhqckvxXTLg5JxDARsjFpDw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCH 1/2] perf: Be compatible with all python versions when fetching ldflags
To:     Sam Lunt <samueljlunt@gmail.com>
CC:     He Zhe <zhe.he@windriver.com>, Jiri Olsa <jolsa@redhat.com>,
        peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, namhyung@kernel.org,
        linux-kernel@vger.kernel.org
From:   Arnaldo Melo <arnaldo.melo@gmail.com>
Message-ID: <D0DBFE8F-632A-446E-941A-980A511C26FD@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On March 25, 2020 5:31:15 PM GMT-03:00, Sam Lunt <samueljlunt@gmail=2Ecom>=
 wrote:
>On Wed, Mar 25, 2020 at 2:26 PM Arnaldo Carvalho de Melo
><arnaldo=2Emelo@gmail=2Ecom> wrote:
>>
>> Em Wed, Mar 25, 2020 at 09:40:34AM -0500, Sam Lunt escreveu:
>> > On Wed, Mar 25, 2020 at 8:30 AM Arnaldo Carvalho de Melo
>> > <arnaldo=2Emelo@gmail=2Ecom> wrote:
>> > >
>> > > Em Mon, Feb 17, 2020 at 10:24:27AM +0800, He Zhe escreveu:
>> > > >
>> > > >
>> > > > On 2/17/20 6:22 AM, Jiri Olsa wrote:
>> > > > > On Fri, Feb 14, 2020 at 02:21:05AM +0800,
>zhe=2Ehe@windriver=2Ecom wrote:
>> > > > >> From: He Zhe <zhe=2Ehe@windriver=2Ecom>
>> > > > >>
>> > > > >> Since Python v3=2E8=2E0, with the following commit
>> > > > >> 0a8e57248b91 ("bpo-36721: Add --embed option to
>python-config (GH-13500)"),
>> > > > > we got similar change recently=2E=2E might have not been picked
>up yet
>> > > > >
>> > > > > =20
>https://lore=2Ekernel=2Eorg/lkml/20200131181123=2Etmamivhq4b7uqasr@gmail=
=2Ecom/
>> > > >
>> > > > Thanks for pointing out=2E
>> > >
>> > > So, just with your patch:
>> > >
>> > > [acme@five perf]$ rm -rf /tmp/build/perf ; mkdir -p
>/tmp/build/perf
>> > > [acme@five perf]$ make PYTHON=3Dpython3 -C tools/perf
>O=3D/tmp/build/perf install-bin |& grep python
>> > > =2E=2E=2E                     libpython: [ OFF ]
>> > > Makefile=2Econfig:750: No 'Python=2Eh' (for Python 2=2Ex support) w=
as
>found: disables Python support - please install python-devel/python-dev
>> > >   CC       /tmp/build/perf/tests/python-use=2Eo
>> > > [acme@five perf]$
>> > >
>> > > [acme@five perf]$ rpm -q python2-devel python3-devel python-devel
>> > > package python2-devel is not installed
>> > > python3-devel-3=2E7=2E6-2=2Efc31=2Ex86_64
>> > > package python-devel is not installed
>> > > [acme@five perf]$
>> > >
>> > > [acme@five perf]$ cat
>/tmp/build/perf/feature/test-libpython=2Emake=2Eoutput
>> > > /bin/sh: --configdir: command not found
>> > > [acme@five perf]$ cat /tmp/build/perf/feature/test-libpython
>> > > test-libpython=2Emake=2Eoutput        =20
>test-libpython-version=2Emake=2Eoutput
>> > > [acme@five perf]$ cat
>/tmp/build/perf/feature/test-libpython-version=2Emake=2Eoutput
>> > > /bin/sh: --configdir: command not found
>> > > [acme@five perf]$
>> > >
>> > >
>> > > Without your patch:
>> > >
>> > > [acme@five perf]$ rm -rf /tmp/build/perf ; mkdir -p
>/tmp/build/perf
>> > > [acme@five perf]$ make PYTHON=3Dpython3 -C tools/perf
>O=3D/tmp/build/perf install-bin |& grep python
>> > > =2E=2E=2E                     libpython: [ on  ]
>> > >   GEN      /tmp/build/perf/python/perf=2Eso
>> > >   MKDIR    /tmp/build/perf/scripts/python/Perf-Trace-Util/
>> > >   CC     =20
>/tmp/build/perf/scripts/python/Perf-Trace-Util/Context=2Eo
>> > >   LD     =20
>/tmp/build/perf/scripts/python/Perf-Trace-Util/perf-in=2Eo
>> > >   CC       /tmp/build/perf/tests/python-use=2Eo
>> > >   CC     =20
>/tmp/build/perf/util/scripting-engines/trace-event-python=2Eo
>> > >   INSTALL  python-scripts
>> > > [acme@five perf]$
>> > >
>> > > [acme@five perf]$ ldd /tmp/build/perf/perf |& grep python
>> > >         libpython3=2E7m=2Eso=2E1=2E0 =3D> /lib64/libpython3=2E7m=2E=
so=2E1=2E0
>(0x00007f11dd1ee000)
>> > > [acme@five perf]$ perf -vv |& grep -i python
>> > >              libpython: [ on  ]  # HAVE_LIBPYTHON_SUPPORT
>> > > [acme@five perf]$
>> > >
>> > > What am I missing?
>> >
>> > It looks like you are using python3=2E7, but the change in behavior
>for
>> > python-config happened in version 3=2E8
>>
>> Humm, but shouldn't this continue to work with python3=2E7?
>
>Oh, my mistake, I didn't read the output carefully=2E It should
>obviously still work with old versions, yes=2E I actually submitted a
>similar patch, and it seemed to work when I used python 3=2E7=2E I wonder
>if the issue is the "||" operator in the subshell=2E
>
>https://lore=2Ekernel=2Eorg/lkml/20200131181123=2Etmamivhq4b7uqasr@gmail=
=2Ecom/


I'm aware of your path, even for confused by your comment here, will it tr=
y it tomorrow

>
>
>> - Arnaldo
>>
>> > > [acme@five perf]$ cat /etc/redhat-release
>> > > Fedora release 31 (Thirty One)
>> > > [acme@five perf]$
>> > >
>> > > - Arnaldo
>>
>> --
>>
>> - Arnaldo

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E