Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Mar 2020 06:50:36 +0530
From:   Bhaskar Chowdhury <unixbhaskar@gmail.com>
To:     Thorsten Leemhuis <linux@leemhuis.info>
Cc:     rdunlap@infradead.org, joe@perches.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] : kernel-chktaint : Fixed space ,cosmetic change
Message-ID: <20200326012036.GA985@ArchLinux>
Mail-Followup-To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        Thorsten Leemhuis <linux@leemhuis.info>, rdunlap@infradead.org,
        joe@perches.com, linux-kernel@vger.kernel.org
References: <20200324225917.26104-1-unixbhaskar@gmail.com>
 <3ca78f7a-4431-b345-85e4-eb07fa8a4038@leemhuis.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
In-Reply-To: <3ca78f7a-4431-b345-85e4-eb07fa8a4038@leemhuis.info>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 12:23 Wed 25 Mar 2020, Thorsten Leemhuis wrote:
>Lo! Thx for taking a look at this, but it seems a few small details need
>to be improved before this can be applied. A few general issues first:
>
>* your patch v2 is afaics on top of the first patch; when doing further
>revisions please merge all your changes into one patch so everything you
>want to do can be done in one commit (and people that see this mail
>out-of-context can easily gasp what this is all about).
>
>* tools/debugging/kernel-chktaint was added via the docs tree, thus I
>think it's best if this change takes the same route, so please CC the
>docs maintainer Jonathan Corbet <corbet@lwn.net>
> and linux-doc@vger.kernel.org
> =E2=80=93 I might be wrong with that line of thought, but Jonathan will k=
now
>for sure.
>
>Am 24.03.20 um 23:59 schrieb Bhaskar Chowdhury:
>> Space bwtween
>
>Typo
>
>> the words is fixed at the bottom of the file,sentence
>
>Missing space after the comma.
>
>> starting with "Documentation....."
>>=20
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>>  tools/debugging/kernel-chktaint | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-ch=
ktaint
>> index 74fd3282aa1b..1af06bc0e667 100755
>> --- a/tools/debugging/kernel-chktaint
>> +++ b/tools/debugging/kernel-chktaint
>> @@ -198,6 +198,6 @@ fi
>>  echo "Raw taint value as int/string: $taint/'$out'"
>
>This used to be the last time. Did you move it upwards on purpose?
>
>>  echo
>
>If you add a blank line here you IMHO might want to add one above the
>""Raw taint value" as well.
>
>>  echo "For a more detailed explanation of the various taint flags see be=
low pointers:"
>> -echo "1) Documentation/admin-guide/tainted-kernels.rst in  the Linux ke=
rnel sources"
>> +echo "1) Documentation/admin-guide/tainted-kernels.rst in the Linux ker=
nel sources"
>>  echo "2)  https://kernel.org/doc/html/latest/admin-guide/tainted-kernel=
s.html"
>There are two spaces here as well: "2)  https".
>
>And I for one dislike the "1)" "2)" style, as in the end it's the same
>file in different locations. How about a text like this instead:
>
>```
>For a more detailed explanation of the various taint flags see
>Documentation/admin-guide/tainted-kernels.rst in the Linux sources which
>is also available online as rendered webpage at
>https://kernel.org/doc/html/latest/admin-guide/tainted-kernels.html"
>```
>
>Feel free to improve on that, it's just a suggestion. I for one wonder
>if this cosmetic change is worth all of this, but no worries.
>
>Note, you also want to change tainted-kernels.rst, as in once place it
>shows the output of this tool (which is one more reason to route this
>via the docs tree).
>
>Ciao, Thorsten

Thanks a bunch, Thorsten ....I think we all should forget about this
event altogether ...this is not worth a single second of our time
=2E..honestly...

crapping it ...let it be what it is ..in fact it is looks good in
present form . Too many round to gain too little...nope...

Sorry for trouble.=20

~Bhaskar

--y0ulUmNC+osPPQO6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAl58A2EACgkQsjqdtxFL
KRUAzQf/ewfABqBDF1hGgWdnJt7NJdZ6GcA+r8PhGjSUCCXwtw3h1TzppTmx1p3g
tXRgiGCAAYmvnMQ3wCACoAPBHRMG+gNoRDcV34v4LekHjl1re7ZLBmntikW53SJR
gP/cw6uRLixk53x0xF+eeeTnLcqPO99J/AgksVSOKoMh4DVpTo25aEjISo6ScVKl
U6SbTC1jBAdlfFOJQ8uiibi3TnJeJD+7ihvXFksEtDp7ooEPUFcjOd4Q0OI9nE4h
nVH2peBrLpQ5SzkCN778/fAnMAjSAXtckRd6iwB9efsawTtcZ6jmUdHUHR8clpKN
ZfW3GwhdN8OCqRNwN/oPfdXSFRRgSQ==
=l59c
-----END PGP SIGNATURE-----

--y0ulUmNC+osPPQO6--