Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200325152629.6904-1-kpsingh@chromium.org> <20200325152629.6904-2-kpsingh@chromium.org>
In-Reply-To: <20200325152629.6904-2-kpsingh@chromium.org>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 25 Mar 2020 18:51:50 -0700
Message-ID: <CAEf4BzYomSccqbO2AGbejQV2R2z0jz5GhEFZxuf7SGwtju+e8w@mail.gmail.com>
Subject: Re: [PATCH bpf-next v6 1/8] bpf: Introduce BPF_PROG_TYPE_LSM
To:     KP Singh <kpsingh@chromium.org>
Cc:     open list <linux-kernel@vger.kernel.org>,
        bpf <bpf@vger.kernel.org>, linux-security-module@vger.kernel.org,
        Brendan Jackman <jackmanb@google.com>,
        Florent Revest <revest@google.com>,
        Thomas Garnier <thgarnie@google.com>,
        Yonghong Song <yhs@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        James Morris <jmorris@namei.org>,
        Kees Cook <keescook@chromium.org>,
        Paul Turner <pjt@google.com>, Jann Horn <jannh@google.com>,
        Florent Revest <revest@chromium.org>,
        Brendan Jackman <jackmanb@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Mar 25, 2020 at 8:27 AM KP Singh <kpsingh@chromium.org> wrote:
>
> From: KP Singh <kpsingh@google.com>
>
> Introduce types and configs for bpf programs that can be attached to
> LSM hooks. The programs can be enabled by the config option
> CONFIG_BPF_LSM.
>
> Signed-off-by: KP Singh <kpsingh@google.com>
> Reviewed-by: Brendan Jackman <jackmanb@google.com>
> Reviewed-by: Florent Revest <revest@google.com>
> Reviewed-by: Thomas Garnier <thgarnie@google.com>
> Acked-by: Yonghong Song <yhs@fb.com>
> ---

Looks good to me, so please add by ack, but I think it would be easier
to review if this was combined with patch #4, which adds verifier
support and kernel/bpf/syscall.c support. On its own this patch just
adds random unused stuff.

Acked-by: Andrii Nakryiko <andriin@fb.com>

>  MAINTAINERS                    |  1 +
>  include/linux/bpf.h            |  3 +++
>  include/linux/bpf_types.h      |  4 ++++
>  include/uapi/linux/bpf.h       |  2 ++
>  init/Kconfig                   | 12 ++++++++++++
>  kernel/bpf/Makefile            |  1 +
>  kernel/bpf/bpf_lsm.c           | 17 +++++++++++++++++
>  kernel/trace/bpf_trace.c       | 12 ++++++------
>  tools/include/uapi/linux/bpf.h |  2 ++
>  tools/lib/bpf/libbpf_probes.c  |  1 +
>  10 files changed, 49 insertions(+), 6 deletions(-)
>  create mode 100644 kernel/bpf/bpf_lsm.c
>

[...]