Date: Wed, 22 Feb 2006 11:07:11 -0800
From: Chris Wright <chrisw@sous-sol.org>
To: Corey Minyard <minyard@acm.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Problem with NETIF_F_HIGHDMA
Message-ID: <20060222190711.GB27645@sorel.sous-sol.org>
References: <43FCB1B3.8090101@acm.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43FCB1B3.8090101@acm.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 810
Lines: 18

* Corey Minyard (minyard@acm.org) wrote:
> I was looking at a problem with a new system we are trying to get up and
> running.  It has a 32-bit only PCI network device, but is a 64-bit
> (x86_64) system.  Looking at the code for NETIF_F_HIGHDMA (which, when
> not set on a PCI network device, means that it cannot do 64-bit
> accesses) in net/core/dev.c, it seems wrong to me.

Why would NETIF_F_HIGHDMA if it's 32-bit only PCI network device?
Typically net drivers do pci_set_dma_mask, and set features accordingly.
Then pci_map_* should just work.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/