Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Martin Fuzzey <martin.fuzzey@flowbird.group>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Andrew Lunn <andrew@lunn.ch>
Subject: RE: [EXT] [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt
 controller to fix wake on LAN.
Thread-Topic: [EXT] [PATCH v2 2/4] ARM: dts: imx6: Use gpc for FEC interrupt
 controller to fix wake on LAN.
Thread-Index: AQHWAtDhpmxkSeO+/UmkFKR+dBRcD6hafyPg
Date:   Thu, 26 Mar 2020 07:45:59 +0000
Message-ID: <VI1PR0402MB3600534A60ACE5E658196053FFCF0@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <1585159919-11491-1-git-send-email-martin.fuzzey@flowbird.group>
 <1585159919-11491-3-git-send-email-martin.fuzzey@flowbird.group>
In-Reply-To: <1585159919-11491-3-git-send-email-martin.fuzzey@flowbird.group>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c83a7b9e-c645-46c2-65f4-08d7d159b9fc
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2020 07:45:59.7436
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /56BnJRIj5hJl99zzXNoSVdG+I9D2makTcz+7QZkmIVhCcIa3UJpmJS4/Z3a6iGlTtk/9afcUmLJguo7kZ3jjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3951
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Martin Fuzzey <martin.fuzzey@flowbird.group> Sent: Thursday, March 26=
, 2020 2:12 AM
> In order to wake from suspend by ethernet magic packets the GPC must be
> used as intc does not have wakeup functionality.
>=20
> But the FEC DT node currently uses interrupt-extended, specificying intc,=
 thus
> breaking WoL.
>=20
> This problem is probably fallout from the stacked domain conversion as in=
tc
> used to chain to GPC.
>=20
> So replace "interrupts-extended" by "interrupts" to use the default paren=
t
> which is GPC.
>=20
> Fixes: b923ff6af0d5 ("ARM: imx6: convert GPC to stacked domains")
>=20
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> ---
>  arch/arm/boot/dts/imx6qdl.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.d=
tsi
> index e6b4b85..bc488df 100644
> --- a/arch/arm/boot/dts/imx6qdl.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> @@ -1039,9 +1039,8 @@
>                                 compatible =3D "fsl,imx6q-fec";
>                                 reg =3D <0x02188000 0x4000>;
>                                 interrupt-names =3D "int0", "pps";
> -                               interrupts-extended =3D
> -                                       <&intc 0 118
> IRQ_TYPE_LEVEL_HIGH>,
> -                                       <&intc 0 119
> IRQ_TYPE_LEVEL_HIGH>;
> +                               interrupts =3D <0 118
> IRQ_TYPE_LEVEL_HIGH>,
> +                                            <0 119
> + IRQ_TYPE_LEVEL_HIGH>;

Please remove the property "/delete-property/interrupts-extended;" in below=
 file:
arch/arm/boot/dts/imx6qp.dtsi
>                                 clocks =3D <&clks
> IMX6QDL_CLK_ENET>,
>                                          <&clks
> IMX6QDL_CLK_ENET>,
>                                          <&clks
> IMX6QDL_CLK_ENET_REF>;
> --
> 1.9.1