Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 26 Mar 2020 09:30:19 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     linux-kernel@vger.kernel.org,
        Collabora Kernel ML <kernel@collabora.com>,
        Andrzej Hajda <a.hajda@samsung.com>, icenowy@aosc.io,
        anarsoul@gmail.com, Neil Armstrong <narmstrong@baylibre.com>,
        matthias.bgg@gmail.com, drinkcat@chromium.org, hsinyi@chromium.org,
        megous@megous.com
Subject: Re: [PATCH v4 2/4] mfd: anx7688: Add driver for Analogix ANX7688 chip
Message-ID: <20200326093019.GC603801@dell>
References: <20200318070730.4012371-1-enric.balletbo@collabora.com>
 <20200318070730.4012371-2-enric.balletbo@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200318070730.4012371-2-enric.balletbo@collabora.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 18 Mar 2020, Enric Balletbo i Serra wrote:

> The ANX7688 chip is a Type-C Port Controller, HDMI to DP converter and
> USB-C mux between USB 3.0 lanes and the DP output.
> 
> For our use case a big part of the chip, like power supplies, control
> gpios and usb-c parts are managed by an Embedded Controller, hence,
> this is its simplest form of it. Other users of this chip might
> introduce new functionalities as per their requirements.

Hmm... So first impressions is that this 'driver' doesn't really do
anything useful other than checking the running model.  I think you're
better off using "simple-mfd" and doing the ID check inside the
useful/functional child device driver(s).

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> 
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/mfd/Kconfig         | 11 +++++
>  drivers/mfd/Makefile        |  1 +
>  drivers/mfd/anx7688.c       | 87 +++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/anx7688.h | 39 +++++++++++++++++
>  4 files changed, 138 insertions(+)
>  create mode 100644 drivers/mfd/anx7688.c
>  create mode 100644 include/linux/mfd/anx7688.h

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog