Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1545162ybb; Thu, 26 Mar 2020 02:50:11 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuYxT/ZJyNx/ICbHhDCEPfEkmxNXWeIF1wxxCLJx0QydRkmOWzB1FXl1pSMkV4wRSA/RrbK X-Received: by 2002:aca:ab4b:: with SMTP id u72mr1228392oie.26.1585216211007; Thu, 26 Mar 2020 02:50:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585216211; cv=none; d=google.com; s=arc-20160816; b=hSF2NGVEThP3fvqH3zv1FXKcv70U3aby3c5VW9hPsS3pR28z62P+Pulaj7eWfXxmsJ VKYTD60i6wg3DSMlSj0X9NCN7ZYThMyjNuiPuiJSOeX2EyCm/XRU9kpf4LNWzJk2pdmc oqWMGvw0/+YR7vvmpa/THu0u6rsr3I2X+PcQqNE9/xs9CE8TpARs87TQw6gcBQHevyf8 UlVzKjEKtsyQtpX0qNJ7kgrUI9cQD4BL/pWfbb+6MEVZ9eE6qRYtKlVy3N5bw1UzpbjJ hOgddR1yMtiTwk/cb7Eg805GPhRPDX0bMpr0a8yTkS48J9TSqxSD8m9wtptLFtKQ8Bs4 E94Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=b1Jkw9+4jncFzgEJhbF5Fp7DwB82hfreVWUFU0zNSo4=; b=v2OQf3Mn+gFnAwI2Kjxg08fzL89r73jAb3lPIk3QB9mkp4hn+nQ/gWdzlVCsQw58iu vFQu4AfJDypPoxJ8IK6+snxaJAGekDxGm4XTayvHcpgPl3/C4VE+e/77Lrr7G8ifvj1R 4MNHOHc9fGJXkD3HB9ffOpA2K4BpgQG9cIRzn/CTbZEDt6eY7PdcS57PBqAazoqN22mL xGqWIRPzzeIsEoQEyIXwB5k8KudAIT2WOhA7FOrwJs2hWNUvdgu1JpBYPUvP2kPjUKtE cbnY1NPrknz9FDR8YSAe8KdrLgxoA2CQ11kiTCwMqIbIv82jOUryOIUvHdbwUBEpe29v p5Lw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q21si702547ooq.38.2020.03.26.02.49.58; Thu, 26 Mar 2020 02:50:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbgCZJtT (ORCPT + 99 others); Thu, 26 Mar 2020 05:49:19 -0400 Received: from verein.lst.de ([213.95.11.211]:44824 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727699AbgCZJtS (ORCPT ); Thu, 26 Mar 2020 05:49:18 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 00AE668C65; Thu, 26 Mar 2020 10:49:15 +0100 (CET) Date: Thu, 26 Mar 2020 10:49:15 +0100 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , Christoph Hellwig , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 11/27] ata: fix CodingStyle issues in PATA timings code Message-ID: <20200326094915.GE9596@lst.de> References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <20200317144333.2904-12-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317144333.2904-12-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 03:43:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > * fix the overly long line in ata_timing_quantize() > > * use standard kernel CodingStyle in ata_timing_merge() > > * do not use assignment in if condition in ata_timing_compute() > > * fix non-standard comment style in ata_timing_compute() > > Signed-off-by: Bartlomiej Zolnierkiewicz Looks good, Reviewed-by: Christoph Hellwig