Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1545289ybb; Thu, 26 Mar 2020 02:50:23 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsxsXuMPlwVMay+Ufxrt2HNPEwVB0gj1cUCStz5ZeUXYPNKOwQ2zZLDykAsIvW6cV/mSm+Q X-Received: by 2002:a9d:1b31:: with SMTP id l46mr5224246otl.95.1585216223207; Thu, 26 Mar 2020 02:50:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585216223; cv=none; d=google.com; s=arc-20160816; b=pncELj9cUv+L6CThYlWDFlcqQN6NI9phe73BK2yLeXOH4XGKBNdr//mTUslrzs9PSW FZRA927/Tl32MI0RzPaRYw4M0E1wdswtrTSaG/868O2bgBlhiAtcPykV8GfmISGLmftx s37W1XiDEMVPK5kJbNidnpFDMGg5KUdhqyBOi2fXW1jneXUBb9mL0kijM/P47vfIauw9 A67C0sn9NmoHX+kmHfuJbncD2tRZBJMyOSsQ1ARHcSpr2+qcGobG0LLBOCoPa2J0ATxb 8/L3K8SfJDMZUIu2LmdQlRsDssYZMaxYS22mdaOgZ4kYI4swFDRd0LzNut8HHDjmhhQE Jkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VtfAa6Iedr9ETNMhWRCQNpLVGevsyM/iD3yCL6J7UZI=; b=nIbHut1ppFa2p1DAL1G6HN+iYLWtc42WS0+Do0+peof5NVX+FN1ueLC0nm8gf3Uupa 8R1uqwVJA5vPGzxT0r4o6XWmkZhVJxqaJLvHozGLBUYVVFjumafWvnZiZWRZSN+AmHGQ 7F7TYZh/UIQvpXxAaGop67/Kmab9G/IvBaevr+HwTb6FcfUmoRx/b7EIg9z/tPhqCPAn 0GFKde2x6qlgcVzr+fGYxwIJOikzqhXpJeO7zY9yGLFRgqXPf3uIPRAwYZ8g5FgRJZ9A 4hK9ybu1O9+u24qOULE1cvepqOvdQS3xAicLiUd5mXY2PhPOu/y4wzshnrj0Kfzhrzhu d0fA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f29si730967ooh.85.2020.03.26.02.50.11; Thu, 26 Mar 2020 02:50:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbgCZJsx (ORCPT + 99 others); Thu, 26 Mar 2020 05:48:53 -0400 Received: from verein.lst.de ([213.95.11.211]:44818 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727699AbgCZJsx (ORCPT ); Thu, 26 Mar 2020 05:48:53 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 17CFB68BFE; Thu, 26 Mar 2020 10:48:50 +0100 (CET) Date: Thu, 26 Mar 2020 10:48:49 +0100 From: Christoph Hellwig To: Bartlomiej Zolnierkiewicz Cc: Jens Axboe , Michael Schmitz , Geert Uytterhoeven , Christoph Hellwig , linux-ide@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/27] ata: optimize ata_scsi_rbuf[] size Message-ID: <20200326094849.GD9596@lst.de> References: <20200317144333.2904-1-b.zolnierkie@samsung.com> <20200317144333.2904-9-b.zolnierkie@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317144333.2904-9-b.zolnierkie@samsung.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 03:43:14PM +0100, Bartlomiej Zolnierkiewicz wrote: > Currently the maximum required size of the ata_scsi_rbuf[] is > 576 bytes in ata_scsiop_inq_89() so modify ATA_SCSI_RBUF_SIZE > define accordingly. Looks good, Reviewed-by: Christoph Hellwig Btw, I wonder if we should switch this to a dynamic allocation, as a lot of people are more concerned about kernel size footprint vs dynamic allocations.