Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1754713ybb; Thu, 26 Mar 2020 06:47:11 -0700 (PDT) X-Google-Smtp-Source: ADFU+vumHiRh786oyCxniUHlR4UtqauixR3sMg3uTZsx7eYZCP/yWmTRZgPi3hx9RuTw4WHxf4xC X-Received: by 2002:aca:c4c5:: with SMTP id u188mr33668oif.139.1585230430859; Thu, 26 Mar 2020 06:47:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585230430; cv=none; d=google.com; s=arc-20160816; b=YEDpSl6O5BFLuZ8yzgZMPd3jt5u+hIoEmbjNx1i7WuiDNfYWWuNzMeLp6sjrD4ZWYE FFQ/9EQ+D2NEtRLK42DLKvynSIHROd5s5fNtNuOSTF0sv/ykDxvpH4Qb4V8N6ZUhsSIC rpQum7GSOzu6LIKLuuX+oueylpDcSJAZSg2JMjpBnq6cojXpT8k76j/V7QSQPUxi2Ret wHIo19+QzvcpWnaABKuxl7rs/lw5V1s0pAGLJTnTUd/1mQjBw4H2XM8suDEj78Q2SmEw ScSTmZGQ5l99e91pNWO0e/i0tWhYlUY+D8iH50U7kcfbqsV4xopfvXT14Df2+W4Iq+My SesA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CG/veg1IxI5mOtz7cqnMJ8ClwsJ5ImuRtjY9Hx23LJ0=; b=XxuO2hAhzrPmm62Zfw8TujdswJxhl1httxDSt6y0SECUMYyuGECqeYiqTxLDS2cr1j dQjLIqbCz1usGvimHPbXwd6JTLyUMoL4cbaoYO4UA8ca4mWFY3iWDKmqLU7WyICcLTh/ CijajoYAzGw8kKgpL0hLRWJVPINW0l93eBe8PzvDff2NTYFXTvqwjvUwNlpxtDCyZYGM 8GlVVt3WNvJC+oJOf0IvEii0/fBgsykwrIA/pOtY5hMcPVzGy+IhcMPlYu4VQwjH0GLu 1ZUDPyLL9mNpWUSG68NsIsnrMEZgw2/H2ohtsjYtLcbXdGzvVlGXGKqADWOHah5EIG2n MLIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 67si1086306otj.108.2020.03.26.06.46.57; Thu, 26 Mar 2020 06:47:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727771AbgCZNqc (ORCPT + 99 others); Thu, 26 Mar 2020 09:46:32 -0400 Received: from correo.us.es ([193.147.175.20]:41804 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727612AbgCZNqc (ORCPT ); Thu, 26 Mar 2020 09:46:32 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 07C03F258F for ; Thu, 26 Mar 2020 14:46:31 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id EE012DA3B0 for ; Thu, 26 Mar 2020 14:46:30 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id E1533DA3A0; Thu, 26 Mar 2020 14:46:30 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 19A27DA3A4; Thu, 26 Mar 2020 14:46:29 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 26 Mar 2020 14:46:29 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id EBE1F42EF4E0; Thu, 26 Mar 2020 14:46:28 +0100 (CET) Date: Thu, 26 Mar 2020 14:46:28 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Qian Cai Cc: kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter/nf_tables: silence a RCU-list warning Message-ID: <20200326134628.4eluovllshxidcuu@salvia> References: <20200325143142.6955-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325143142.6955-1-cai@lca.pw> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 25, 2020 at 10:31:42AM -0400, Qian Cai wrote: > It is safe to traverse &net->nft.tables with &net->nft.commit_mutex > held using list_for_each_entry_rcu(). Silence the PROVE_RCU_LIST false > positive, > > WARNING: suspicious RCU usage > net/netfilter/nf_tables_api.c:523 RCU-list traversed in non-reader section!! Applied, thanks.