Date: Wed, 22 Feb 2006 13:16:13 -0800
From: Pete Zaitcev <zaitcev@redhat.com>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: dtor_core@ameritech.net, linux-kernel@vger.kernel.org,
       stuart_hayes@dell.com, zaitcev@redhat.com
Subject: Re: Suppressing softrepeat
Message-Id: <20060222131613.2b6cc64c.zaitcev@redhat.com>
In-Reply-To: <20060222204024.GA7477@suse.cz>
References: <20060221124308.5efd4889.zaitcev@redhat.com>
	<20060221210800.GA12102@suse.cz>
	<20060222120047.4fd9051e.zaitcev@redhat.com>
	<20060222204024.GA7477@suse.cz>
Organization: Red Hat, Inc.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1334
Lines: 34

On Wed, 22 Feb 2006 21:40:24 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:

> Setting autorepeat will not be possible on 'dumb' keyboards anymore by
> default, but since these usually are special forms of hardware anyway,
> like the DRAC3, this shouldn't be an issue for most users. Using
> 'softrepeat' on these keyboards will restore the behavior for users that
> need it.

> +++ b/drivers/input/keyboard/atkbd.c
> @@ -863,9 +863,6 @@ static int atkbd_connect(struct serio *s
>  	atkbd->softrepeat = atkbd_softrepeat;
>  	atkbd->scroll = atkbd_scroll;
>  
> -	if (!atkbd->write)
> -		atkbd->softrepeat = 1;
> -

This looks good to me, because it makes the operation of the code more
straightforward and easier to understand. With our docs always lagging,
it's important.

Like you said, it does "punish" people who had "dumb" keyboards, but if
they really are a special class of folks, maybe it's better that way.

And I think it's much easier to type a command to enable softrepeat
than to type a command to disable softrepeat when all your letters come
in twos and threes :-)

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/