Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Jessica Yu' <jeyu@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "'Linus Torvalds'" <torvalds@linux-foundation.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Matthias Maennich <maennich@google.com>
Subject: RE: modpost Module.symver handling is broken in 5.6.0-rc7
Thread-Topic: modpost Module.symver handling is broken in 5.6.0-rc7
Thread-Index: AdYDiqOPE71nee/CTfS3aDSZbkO5JwABAkKAAABe9DA=
Date:   Thu, 26 Mar 2020 17:06:25 +0000
Message-ID: <90b763cc306140499fddf8e3185e26f5@AcuMS.aculab.com>
References: <931818529b1d4d13a08d30ddace22733@AcuMS.aculab.com>
 <20200326165036.GA22172@linux-8ccs>
In-Reply-To: <20200326165036.GA22172@linux-8ccs>
Accept-Language: en-GB, en-US
Content-Language: en-US
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Jessica Yu
> Sent: 26 March 2020 16:51
> +++ David Laight [26/03/20 16:25 +0000]:
> >Something is currently broken in modpost.
> >I'm guessing it is down to the recent patch that moved the
> >namespace back to the end of the line.
> >
> >I'm building 2 'out of tree' modules that have a symbol dependency.
> >When I build the 2nd module I get ERROR "symbol" undefined message.
> >
> >If I flip the order of the fields in Module.symver to the older order
> >and link with modpost from 5.4.0-rc7 (which I happen to have lurking)
> >it all works fine.
> >
> >Note that I'm using a named namespace, not the default one
> >that is the full path of the module.
> >
> >I'll dig in a little further.
> 
> [ Adding more people to CC ]
> 
> Hi David,
> 
> Could you provide some more details about how I can reproduce the
> issue? As I understand it, you have two out-of-tree modules, and one
> has a symbol dependency on the second? Pasting the modpost error
> messages helps too.

Ok, I've found out what broke it.
Was actually the removal of the code that parsed Module.symvers
from the current directory (which happened for 5.5.0-rc0).

Took some digging and printfs in modpost to find what wasn't happening.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)