Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp2240531pja; Thu, 26 Mar 2020 11:54:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsF9hM48tuOY0JcgA/JxSeq8UH5T/DiRdCLaizpzeUCy6Tn6w/Rv3YW5GfGlzViwMKMnvbw X-Received: by 2002:aca:3101:: with SMTP id x1mr1198326oix.15.1585248846707; Thu, 26 Mar 2020 11:54:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585248846; cv=none; d=google.com; s=arc-20160816; b=PEBtPji1SOHgLM/qDC42FWjT3+4G5EZqpOUMSzjEbWS9rPsg2Ms1C/SoLr24B7nAyY J1eJGrWi02jNzNSa3euPeKX2YUalZytbKLPm7nz1ep4duhQF8LVcEJE1e2106lgj0Nzu ap6unXe97r4WZZels4A8kR7ZTIs0l4nx0rfyODi/mIa1tuQX4L3MKKLv3oCdaeEqspL7 9OSQ1++M2WTt8J//ivrpFoMXQ1hx6YZ1WpRPijDIZOQHpBrXsBFA9LvLCWdvK5QlqFQr gbfKelMkvrmAmWhVnYGN7ozVepPCj4x270Co5PtpgG7FbCmJNHz2hH+LcNOPP1sXg5rX TR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JP/KJJM6MzpKjHpDIVHSNtc5tYTtkmwCbKoZNuRQsVc=; b=GlZ0hux9CuTUaB6o0k+iBpdFztElMBnYdxNGqPiyHl6jrdA+aSPN7ZM/wWo/J2StnZ CmqV2+7SO0U8e//HCdLlNOwT/nCTXlXBGjBBamTnvwVOoGDhCdrinUPMtJ3SzCYsGsUT Dt3BATYnUvGiNpuqWidbE4Am86EdsjeKZ7ep1xEUqk1dEApCKQP1QagjIShDPEh0I8Kj MbykgdtDy7QxhMlAJ3zm3Jmg5LgWISTDZzdCRe9nKNBRM++/PHsTqow2cING31E2jlxV 1ZZ37iCP10E7SgYTSSfCUK8gAgYp0tvAP0pDXAka8RXmo06d//XvHX7pw0+WwRuj18DW rE/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w29si1515987oth.24.2020.03.26.11.53.52; Thu, 26 Mar 2020 11:54:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727919AbgCZSxd (ORCPT + 99 others); Thu, 26 Mar 2020 14:53:33 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52714 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726340AbgCZSxc (ORCPT ); Thu, 26 Mar 2020 14:53:32 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 335FF15CBC23B; Thu, 26 Mar 2020 11:53:31 -0700 (PDT) Date: Thu, 26 Mar 2020 11:53:30 -0700 (PDT) Message-Id: <20200326.115330.2250343131621391364.davem@davemloft.net> To: florinel.iordache@nxp.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, kuba@kernel.org, corbet@lwn.net, shawnguo@kernel.org, leoyang.li@nxp.com, madalin.bucur@oss.nxp.com, ioana.ciornei@nxp.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 6/9] net: phy: add backplane kr driver support From: David Miller In-Reply-To: <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> References: <1585230682-24417-1-git-send-email-florinel.iordache@nxp.com> <1585230682-24417-7-git-send-email-florinel.iordache@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 26 Mar 2020 11:53:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florinel Iordache Date: Thu, 26 Mar 2020 15:51:19 +0200 > +static void kr_reset_master_lane(struct kr_lane_info *krln) > +{ > + struct phy_device *bpphy = krln->bpphy; > + struct backplane_phy_info *bp_phy = bpphy->priv; > + const struct lane_io_ops *lane_ops = krln->bp_phy->bp_dev.lane_ops; Please use reverse christmas tree ordering for local variables. Please audit your entire submission for this issue. Thank you.