Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp2373514pja; Thu, 26 Mar 2020 14:10:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vu7Q1QaoVGdWU4fS2KXiEVFI2/uVWxNsqnzmlrnKdcK4bZt+qiBDJ57le1sllua+NDE82r4 X-Received: by 2002:aca:310a:: with SMTP id x10mr1661474oix.151.1585257006396; Thu, 26 Mar 2020 14:10:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585257006; cv=none; d=google.com; s=arc-20160816; b=TtXAyHOfdF8SPjyi9MlvWLCA6MtvRzXYpT924ZhYKpmfgDaHLroQ7CRTbjM8MaHstw LOIC2USWmmakRBRPnNMN3jA9pV62P9PdoQ3/BTy++G4We9zeuedaMmG+yCwdvxjd0373 FAxJ8jSAF7a4NiSQXsMaRQtAevIxS4iVtjGX7/ZzpBUfsyfwdtR9akOd+5g/12rVBQEH jfJlyGDc3vJw3HSHmNa3OsTRQIhjCHAvxeJBXacfDYIVUojT+lCHkUtZ+KR0nHCN5IbX Qr03n1iJOnPwTG4iyw23vdiOu/Nghy4RNMDJVr4hzY0yO8CuOJ1Qwe2VHKrDDFr5MryG ucaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qAyBvgO4bOnc2gaynrGXEwwg2q9+bev/7Krv5slmOVU=; b=KaxLwlmBAwAWmxBUWwrWpeMCSbOYfPYGTTwHf5kgJhZQ2LWLBtYBcM7G9TYlY/7gD/ 24ARtAKbL4xcXN50j6TZJTTKYgUaZ9SnocW1Vrm5/CWk4WlWsWk3ErIdinxbWd20Mrvg r/tnORcnjhZ/APX7f5v1p2uix14d74OFnjSGbMXleyN+LcFzK8IpqqgVLRXmf/ogpXKD oaNHSnetKkxxNcreyPHzi0fEV3b+3v3Arq9v3awGvrboWEC6AF1IMDVzTbNjFNl2CYge 6g0NTSk2ggKWn1XB2tLYjrKqjReNSIR9ibGTu7hQzbj10z432T42rVrUUaYHm9vwlCaU 2D/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qAM3YCcZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r184si1419192oie.79.2020.03.26.14.09.52; Thu, 26 Mar 2020 14:10:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qAM3YCcZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727652AbgCZVIG (ORCPT + 99 others); Thu, 26 Mar 2020 17:08:06 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:43244 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727473AbgCZVIF (ORCPT ); Thu, 26 Mar 2020 17:08:05 -0400 Received: by mail-lj1-f196.google.com with SMTP id g27so7957730ljn.10 for ; Thu, 26 Mar 2020 14:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qAyBvgO4bOnc2gaynrGXEwwg2q9+bev/7Krv5slmOVU=; b=qAM3YCcZs+npTx9BPPePlvKxpXslhpkUmEgugnm4zAlkgCuERkzo5/Ny5AqJKWuNI0 ee9NxL1Vene0EIe9MIIcEKVSNl3ELO9DzQV1v6OPZG/ymJS0GzpS5HpxEvajOFYGjLg/ 8hTPoBBa+SZXYZv6GDDVEZOCIWiZqN1g2fSUO5WXwcWQv99jmowC0bv5jm8HQyAY9R0W WdBbuyvVCJZ2oMFZsQJAT+IreTv93hXErVplWvMb+uKMkrZFThR29bTqy3mIrEYIHPb1 cOi1OYNIA3oIG4m5I6aUIgAH2xkWc7L3IilysL0bNP6jOWASQMrsZRbeWVUn4aYTPotV ivYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qAyBvgO4bOnc2gaynrGXEwwg2q9+bev/7Krv5slmOVU=; b=AcTWSa4/rOu9nLdi2VLHEp13ZznHyFOq9hkCAMiplKVjoC40d2vCzutTC+S0Fx0x/U g3ha9N/fTSK4Tne8vt1YncXa19loumSO5VNyUgK0lX/kJZqMxA+eHHF3zYSxvj/Rm/4e CEgSYVd/4JnGHBn1F/iOgjrLtiuU2DDpRXdMWiWGuWQPiaSuHsup4TL5bpQQzzEdtUPH Vctb3mEJApWQnxtyYqliVPjgu6RyGjeJYNsfwyOtAJJmjdXsddg5bP46QWW4lVIkepf4 2L8NqSqUwlCY+XDRSvFZjV6/CEb3gzpoLsd4XFP3XG0My0+Gsl8Uu6eKZvGl/CvoohFp NFyg== X-Gm-Message-State: AGi0PubaUVpyc7w0V0HBBvNkPcVA80vfZQ/nvGca6PLfKs+91jyxRykw nI8JgaAGHlncMhQ3nLuqJS9sx4un7fW+DH8I+3SIzw== X-Received: by 2002:a05:651c:28a:: with SMTP id b10mr3830382ljo.223.1585256882978; Thu, 26 Mar 2020 14:08:02 -0700 (PDT) MIME-Version: 1.0 References: <20200324135328.5796-1-geert+renesas@glider.be> <20200324135653.6676-1-geert+renesas@glider.be> In-Reply-To: <20200324135653.6676-1-geert+renesas@glider.be> From: Linus Walleij Date: Thu, 26 Mar 2020 22:07:51 +0100 Message-ID: Subject: Re: [PATCH v6 1/8] ARM: integrator: impd1: Use GPIO_LOOKUP() helper macro To: Geert Uytterhoeven Cc: Bartosz Golaszewski , Jonathan Corbet , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , Rob Herring , Mark Rutland , "open list:GPIO SUBSYSTEM" , Linux Doc Mailing List , Linux-Renesas , "linux-kernel@vger.kernel.org" , QEMU Developers , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 2:57 PM Geert Uytterhoeven wrote: > impd1_probe() fills in the GPIO lookup table by manually populating an > array of gpiod_lookup structures. Use the existing GPIO_LOOKUP() helper > macro instead, to relax a dependency on the gpiod_lookup structure's > member names. > > Signed-off-by: Geert Uytterhoeven > Cc: linux-arm-kernel@lists.infradead.org > --- > While this patch is a dependency for "[PATCH v6 4/8] gpiolib: Add > support for GPIO lookup by line name", it can be applied independently. > But an Acked-by would be nice, too. I simply applied this patch for v5.7 in the GPIO tree since I am the maintainer of this platform, and I might want to change stuff around Integrator next cycle so it's good to have this covered. Yours, Linus Walleij