Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2025668ybb; Thu, 26 Mar 2020 19:57:06 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuBc01WwC2KG3HxHnWXOrUa9kJzrKm6xCEmnHhm4cw2iPLTbdlZ61OwOu14nv4dBgNYIWzT X-Received: by 2002:a4a:4547:: with SMTP id y68mr4353544ooa.58.1585277825888; Thu, 26 Mar 2020 19:57:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585277825; cv=none; d=google.com; s=arc-20160816; b=PPzxz1epaGswTzM9YwIuGH3pzdGTDS95Z0mfFI42jpPdRtW1ZGW2CWaKsIN+nM38gB TTtVJHOY28ygAA7jLiZGIlUQ/LVxmeSgVLSAx4Mssv7NA4DR4uzlV0hVc21y1FVZTsY1 LsSYEkJBpO2o3dH+sO0FRsl4u8vMEn0HIIAlb/F2a77QhU/C2CPfRCoz8La5l+ZXTZU9 3w1fUS/CvUWmJunOx/JhGLCh0Z7BjWBjFTYPjkKA11UgwNd/vyZgtlZy1/uyo31vyS33 8ny1BOkdQBPh/zS33DjR1dYHiaaz32k8WzEQgOle9Lqykty4L/1UtTobzZAruAHVOjp0 fp7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=n5Kcdu+4pUBMOADSPXLw+5tPpkEAkjfQRELCDZz/nTQ=; b=dZkrMP6KAdVl5SV9R66vER+3zfbPE74wJwVO21XE/T/6+IRf5oxbCVT4ridlVWXbVO 0ijcIbDPUs6ftMmC6+XIOxxBWIc+zPsMAMuFncKZMqdv/i5k/NbxB9e3NtGXhjlo/moH UGUKcCfSXERW2U7FfV4LEJe1V5i63cx8j0Yze9tsYXeT7S6O1z4NY0wHQACJYL84vUgy watavXlIViLafd26KZDEhCKnXCo2ac/lgoTP18HJ7xwHe1ekuQQ2zjllvgTUf4YG/bbG Wz7n+XiQkmYMQ+VxKoJtwYHV6RZZH+FjN8rU+xf1HyA1r9P2LAQK4lesgMYYzn3DHrhp EaRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KwAkr6OA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w6si1831132ool.11.2020.03.26.19.56.52; Thu, 26 Mar 2020 19:57:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KwAkr6OA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727677AbgC0C4f (ORCPT + 99 others); Thu, 26 Mar 2020 22:56:35 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40893 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726363AbgC0C4f (ORCPT ); Thu, 26 Mar 2020 22:56:35 -0400 Received: by mail-wr1-f66.google.com with SMTP id u10so9702998wro.7; Thu, 26 Mar 2020 19:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=n5Kcdu+4pUBMOADSPXLw+5tPpkEAkjfQRELCDZz/nTQ=; b=KwAkr6OA/lO9BVjCg/pqTzlTVWu3zrQS56Wdnf0jeHwF6zH68cpAFmqdIDjgn/zuF1 66USQlTuJ0NVUiG4q8rsn7MADHNyke6jO85L6orK6X/LdARljnf3Jc+GXh0Vb9WFZBXr //Fx5n3t8FjyIDFjhO51wm4DU5gmhXVi1MdtoKtJI3aSGaht6z1MTfdggxSdqBWZTQ7l e3ginuquv7WExMo0rVHt2+bRyTIpRDgZ8SWIiNTikvNVNl9T+fu+XvrVuS/tAv+n2Zn+ XBMWvlZddsw0MyaqfYIh2Jky7hFXwDzZd41SNzEQB0xNuSBlAcbB0FNbyXfD6KgMzu2X 70Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=n5Kcdu+4pUBMOADSPXLw+5tPpkEAkjfQRELCDZz/nTQ=; b=JF6swbor68K9VIsKJ7wcvduxMGw8souI7Xfj/M4Cuuo2whkOPTuZxrETz6941ErLdO QHzQlQHD7MALV8MxMHmVGwSZmg4cdyZknaPvHuH1/GxTLCVELh2A0O9lJEZ34oEV8MaY CPm2LU5lcmi/hXAuqukOWzd6jyfk78tXKjpR8bijzx3BeIL3340R3Sp1qDjHEvfABI1M ZrZIlJkp3H0R5IjMvK9mvQCcUQ46vv8VFfuPnP0hwTMBkU6+Tg8IDGIhm5D2hCrEeoVG rHRREYavT2EtGHXXK5FJPoYB99NNKDEdOvPDItSVKr9XZTmZHCFujw5yrqlid6sH2JFX 1afA== X-Gm-Message-State: ANhLgQ0iE43De4CaH8kkEejm5C6yUaUpclLvG2HVxTBHozejjSoX7Lcl 3TuUCR5Pu/hatxudoLyKziVVqiry X-Received: by 2002:a5d:4ad1:: with SMTP id y17mr12010171wrs.13.1585277793621; Thu, 26 Mar 2020 19:56:33 -0700 (PDT) Received: from [10.230.186.223] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9sm5877812wmb.21.2020.03.26.19.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Mar 2020 19:56:32 -0700 (PDT) Subject: Re: [PATCH] ethtool: Report speed and duplex as unknown when device is runtime suspended To: Kai-Heng Feng , davem@davemloft.net, kuba@kernel.org Cc: alexander.duyck@gmail.com, Jeff Kirsher , Aaron Brown , Michal Kubecek , Andrew Lunn , Maxime Chevallier , "open list:NETWORKING [GENERAL]" , open list References: <20200327024552.22170-1-kai.heng.feng@canonical.com> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Thu, 26 Mar 2020 19:56:29 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327024552.22170-1-kai.heng.feng@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/26/2020 7:45 PM, Kai-Heng Feng wrote: > Device like igb gets runtime suspended when there's no link partner. We > can't get correct speed under that state: > $ cat /sys/class/net/enp3s0/speed > 1000 > > In addition to that, an error can also be spotted in dmesg: > [ 385.991957] igb 0000:03:00.0 enp3s0: PCIe link lost > > Since device can only be runtime suspended when there's no link partner, > we can directly report the speed and duplex as unknown. > > Cc: Jeff Kirsher > Cc: Aaron Brown > Suggested-by: Alexander Duyck > Signed-off-by: Kai-Heng Feng I would push this to the responsibility of the various drivers instead of making this part of the standard ethtool implementation. -- Florian