Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2068854ybb; Thu, 26 Mar 2020 21:06:22 -0700 (PDT) X-Google-Smtp-Source: ADFU+vse4I6rQyXaJS4HnG0cjd4iLPnl8p2UfHapqnThHD/D8AADfhlrDuZsGK2igB4+8f3RxFTm X-Received: by 2002:a05:6808:6d6:: with SMTP id m22mr2617946oih.164.1585281982426; Thu, 26 Mar 2020 21:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585281982; cv=none; d=google.com; s=arc-20160816; b=TYNm6fvRsWCzBDmIS0SF8zDUApAsaZtlA+1fSL41zD9ZCi3nPPU/kAqnl22/PML1jp nhZlNP7+fNDF2QafMB6tCtDXeE+oH6A28/oz0wxUK93AgXJt2CCmVfNrJUpZXkGcHQEv H5LvgQmEkRGeUDJRZlim/x7SwljVUsChpCzp3EtF4qI0+c5xjp+3GSUP0419kilbdGvR 2NDU3uPhEIIrhCYTyUH+bAD3e2z6wh2TGoSbdN4GIQjY3s09cY+2UX5OMFVGvg8D+mlK DiC1KgoyVGwJxxbMW2znQVKe5xmKK82gbQ3eulfyeWYqA3i1CHmCJjBR3gouSbd4ECvS Zmow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GByrdXs6lcU5kCSOoxR0ATrYfBsPPkiO/r5cVnhRM/k=; b=uGfQUBxLKnH6zExnQPfOkkFezy9mbxlRLt+7ppI0HtZVFBaDd9u8GAyDKUOHiyGduE 6npw6tzACTUjbGLr+E1nCzla/Rc6MECLUO2j3KZoHYWWnN1L/bCve+NEkO+X6FCNaHYk X3Iw7AtT6AHzGX/Sk3uabfzDJRHfJ9K6pXHPLHrOVLwB1NgG8YvNSfgwmIGlPNYHPr+6 xQSEoM9f6TOK98qvbOvwcPvlRFsR5dXgag7NZc97zssjbrwk1TQbtC8NaDo8jSvVvyx7 2dyTn7fUETxfC29C5Jo0bkt7RWHSzZJjIL7izDAUq7KOT18w3efa6h7iXQRcCHIx1zqD OqGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="BrumY6/t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61si952798otb.20.2020.03.26.21.06.09; Thu, 26 Mar 2020 21:06:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="BrumY6/t"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbgC0EFq (ORCPT + 99 others); Fri, 27 Mar 2020 00:05:46 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:44863 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgC0EFq (ORCPT ); Fri, 27 Mar 2020 00:05:46 -0400 Received: by mail-qk1-f195.google.com with SMTP id j4so9513299qkc.11; Thu, 26 Mar 2020 21:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GByrdXs6lcU5kCSOoxR0ATrYfBsPPkiO/r5cVnhRM/k=; b=BrumY6/taf+vJ22SnRyZhu8VL/uvIlkZ5nGyN1Z2tO3Xa5r/K1Pz/+s+hXq+q1ODbl y5Qy0GnSv0KSzloJXKu57s38KifyWL4IJ2b9ZGmZrhsMcdeNJq39uRa0OK4FACxyJxgZ r1wWvNeri4P++8cT4k2cEMtKv4dJLaTG/nJU5RWtGfUPay//uKzgtLAJSgjj98TXWeyB JWwp+aNBpWhHYFe5W2xyPqmHRyhl2RwMJQmWv4061eCHpgsosSYCCqfErLJ+8F/cpMkL O6Ym4Wlm9ziVtgZGupnVHF0WjOKMafcxqJvA6njcQldmnlRIG6R44gLNHX08Wtj5iedg 2f/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GByrdXs6lcU5kCSOoxR0ATrYfBsPPkiO/r5cVnhRM/k=; b=mkcEf0SIhyvNY62FeHu0k3XiPjPAYMu3kXBTkUVs3kmkBw9Ar0qZievqYZ35K22Hvv gPI7mgze4yZDimlcltSnd8cgs+yBVQvZyIO2xzW6M8TN091R9z2bsnofd4lBQybe6h4t dphBs56wmEf6wwGESfEcrtwt6A9vEnu10MoFVy689Y6wjm32AFtKJfgSTSKs3I974X/4 wQLsjeTQjeMaDlzYG0ZtI4bf5lls6FEnsN3nOabapsbORvKRB3zg3Eg/mKR0gZtiekQM jgLLJ7r4JrlEr7byJRHHODMPkfFvhwZJ30CPSbiD3OnPUNNL8IiDeNOJQZZAQ8DNrbPA D+MA== X-Gm-Message-State: ANhLgQ02c1ZBQk/8Xd4Uydhg+B1LKV8W0zD7kxe1Mu/Ty+bm/11+8WN0 3lfrv7aosM8qRPOWrALYHNU= X-Received: by 2002:a37:a614:: with SMTP id p20mr12236940qke.114.1585281937701; Thu, 26 Mar 2020 21:05:37 -0700 (PDT) Received: from localhost.localdomain ([168.181.48.248]) by smtp.gmail.com with ESMTPSA id q1sm3250572qtn.69.2020.03.26.21.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 21:05:36 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id 24712C5CE4; Fri, 27 Mar 2020 01:05:34 -0300 (-03) Date: Fri, 27 Mar 2020 01:05:34 -0300 From: Marcelo Ricardo Leitner To: Qiujun Huang Cc: davem@davemloft.net, vyasevich@gmail.com, nhorman@tuxdriver.com, kuba@kernel.org, linux-sctp@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, anenbupt@gmail.com Subject: Re: [PATCH v6] sctp: fix refcount bug in sctp_wfree Message-ID: <20200327040534.GK3756@localhost.localdomain> References: <20200327030751.19404-1-hqjagain@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327030751.19404-1-hqjagain@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2020 at 11:07:51AM +0800, Qiujun Huang wrote: > We should iterate over the datamsgs to move > all chunks(skbs) to newsk. > > The following case cause the bug: > for the trouble SKB, it was in outq->transmitted list > > sctp_outq_sack > sctp_check_transmitted > SKB was moved to outq->sacked list > then throw away the sack queue > SKB was deleted from outq->sacked > (but it was held by datamsg at sctp_datamsg_to_asoc > So, sctp_wfree was not called here) > > then migrate happened > > sctp_for_each_tx_datachunk( > sctp_clear_owner_w); > sctp_assoc_migrate(); > sctp_for_each_tx_datachunk( > sctp_set_owner_w); > SKB was not in the outq, and was not changed to newsk > > finally > > __sctp_outq_teardown > sctp_chunk_put (for another skb) > sctp_datamsg_put > __kfree_skb(msg->frag_list) > sctp_wfree (for SKB) > SKB->sk was still oldsk (skb->sk != asoc->base.sk). > > Reported-and-tested-by: syzbot+cea71eec5d6de256d54d@syzkaller.appspotmail.com > Signed-off-by: Qiujun Huang Acked-by: Marcelo Ricardo Leitner Thanks Qiujun.