Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2075435ybb; Thu, 26 Mar 2020 21:17:13 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2issAGS/jU/moCK+k89JSApJCNutpLoYAGP+SCYYiDUtij9dj5T0X6FDuZ44j3fUjrJdV X-Received: by 2002:a54:410c:: with SMTP id l12mr2798056oic.13.1585282633384; Thu, 26 Mar 2020 21:17:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585282633; cv=none; d=google.com; s=arc-20160816; b=MH32alH+eTpjtQsl4eaePv2Vqo8jxyV0KpCuvq32i77CeQxZl5h52Uv3n7SBlCPnVl MrsJfivnBNxuuCaBA28PSVChmZ0qcyWJgkTmqzXdFirv49G/3lK+kz2pSqCJwHsJrgoT HOuyXuTQdnRrdLLI8kEx6L4LyGzCamXlAqEeME2Dxhei9r1rMy4sorfDL6ZWxvrYG5DV zkWHXeWW1GC0GlSFcJVQhHvKzc2ybv2TFruvwW4ebyj9qpx+6RAI7pTD0fw+MqjMbMQD nO2RWh5aZ7pyjr92UROYQmDoYeRTHTzR1Vh6onl9o9e2xophpcNOctRig/w2U305lP+t 0f+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=UTVnm2DzKzOSeeN1mEdgWcMrxXISeDeq6HNDUTaelVw=; b=jmGSXPps8/VEIVr3SOmowjcchuzjFlAnaaVwrPG+kVEWutnUMorBxPiBZUw2fsC5m2 twBXc6PHbvXzThauVCgrnymxsTTRX1Ei2jrhP7PpCDATyuKM3aA/hkKh/E9OpxDlPANW vq6rIn10cc1JQ80qGB7uNWHgI2KxzRbbCRB0uOY3fSBrhiNHEGjNTw9nmpQ7eZB5SGGm toU3Rr5cDPOapx5eYbgAx/qNmo3Dd0a7ZFGE4KoBnjNjMCUPhTR1jOWZsKCRUosgM4qM PTDmJzjot7btpm4XTDHEvQ+dOU8z43U93Fm2FN3JoUa34GCwVTnfuxsEayyzoPMXfrKg cHyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=quKFvuyz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13si1854600oij.140.2020.03.26.21.16.53; Thu, 26 Mar 2020 21:17:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=quKFvuyz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726149AbgC0EQI (ORCPT + 99 others); Fri, 27 Mar 2020 00:16:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:56566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgC0EQI (ORCPT ); Fri, 27 Mar 2020 00:16:08 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4815520575; Fri, 27 Mar 2020 04:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282567; bh=MPqAiPXpN5JEkst6TsHe7SkHCTDCe2DIkSuHMQ7/dms=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=quKFvuyz12eu/G9oWjWmPb1R2W8+1AEE+hw7Bl+9O57Uy07ZsDD007nRvzia+GCVv 5MYYmypeP5931n/0LABmOuiShM30MTWgEnAhlTR5dnuJbuMaBv/4KGhv4L7tvj36Pe FKKcQf+OwiuJoRaZ3XyPuHKiAth54sUoaMRotbHo= Date: Thu, 26 Mar 2020 21:16:05 -0700 From: Jakub Kicinski To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 02/12] ethtool: provide coalescing parameters with COALESCE_GET request Message-ID: <20200326211605.6f80f9c7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <0d94d1390e886c2d616291c46509fac4cd9eac11.1585267388.git.mkubecek@suse.cz> References: <0d94d1390e886c2d616291c46509fac4cd9eac11.1585267388.git.mkubecek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 01:11:57 +0100 (CET) Michal Kubecek wrote: > Implement COALESCE_GET request to get coalescing parameters of a network > device. These are traditionally available via ETHTOOL_GCOALESCE ioctl > request. This commit adds only support for device coalescing parameters, > not per queue coalescing parameters. > > Omit attributes with zero values unless they are declared as supported > (i.e. the corresponding bit in ethtool_ops::supported_coalesce_params is > set). > > Signed-off-by: Michal Kubecek Reviewed-by: Jakub Kicinski