Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2075565ybb; Thu, 26 Mar 2020 21:17:26 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsuGbChQZDWLj0D6Q4fNVVZ/cJQc90MparTGROsB+nQz65ZPlfDgAjT+6WWCfXR2l91twES X-Received: by 2002:a05:6830:22c3:: with SMTP id q3mr6828641otc.152.1585282646528; Thu, 26 Mar 2020 21:17:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585282646; cv=none; d=google.com; s=arc-20160816; b=p5MV6JRLN2ozECfXJr5GRsl+CoA7S642AAaIzu8cTe6mjyOHRZlUvN7ZJnMQ4HOCkZ nK16VL1TJC3pmj/n6Ny9ELIJdTXnMzxw90eU5jk779S/LaHbej+8yGpV9IUpkIAG1epS mFbN3pDKNuCayPe7R3c6h1fnKmOSTQn95IswqLBn4FBJQnQAW+GIyqqTUcw13Z9XOGh7 6wd0Iy4LleD2nRj7LqfhXmKGKyW1RcM9zHtwqZixrxGFPVe+VwXn40Dh82FZMK9mLbeW fbMr7+UQALDR6Gej+XzonE1goXsGlqBAquHl6CCRk5n1WKOx3tXv8GP3w8cnppB9jF+4 XnbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=4egH2pYvwLpCj/YsEdBCRLdZnlKlqaVTfMjhAj7ZdbU=; b=xZGOPHU2jbbAROFPSWepSOWFzMRQZ+8L4SIbkFbIVdng+ff6WrmekGdd5ZPgpKxTy0 ToURNtj6g3QtjGy51bE3h9Pdr2LQECs7iyZ/0PEFXq2xzsZtkA256T8Iu+5BjnCzOAFN MEu8Ok5gi/DdPKNGoJ+Rolp8KjUaw6mQ0w3EaHifqrskGnJJbTA1bGN9m/6NqW5zoh6t gfXaIY87+Rq0VHzGuXRNl8+xKNceRlO3B4+CV0AkcpffyrGEm5cTt0kVy8v8W03JPvIo jkqECmhTvVN8woEgi46Krc3MHRDVnoMDyQM8okAfTFoqkyo5P/XxWxnbiDApWb091HhX kIhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dgPZUxT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j184si1897131oih.216.2020.03.26.21.17.14; Thu, 26 Mar 2020 21:17:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2dgPZUxT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726383AbgC0EQd (ORCPT + 99 others); Fri, 27 Mar 2020 00:16:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:56624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725822AbgC0EQc (ORCPT ); Fri, 27 Mar 2020 00:16:32 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 025A920578; Fri, 27 Mar 2020 04:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585282592; bh=VRn4CmnO4guCD3v0PtWxBdCVigKH7R2NN/+P9WQ6LhA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2dgPZUxTe0hmf+l3SsoeBLj329rzs1nPoy5RXCid7+x7zbHLD2+rGx5Zs9wPe4Ds7 +4hm6xa1wdBJfO9t6Fe4bq8sLttnuv7dAOjjO23RFSn4lZ7CovBOrmX8SPHT8rUcYO HKGKR9DqamA1hJqoK5W+3L9hxTrPF9BjduDEmdOE= Date: Thu, 26 Mar 2020 21:16:30 -0700 From: Jakub Kicinski To: Michal Kubecek Cc: David Miller , netdev@vger.kernel.org, Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/12] ethtool: set coalescing parameters with COALESCE_SET request Message-ID: <20200326211630.41e0329c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Mar 2020 01:12:02 +0100 (CET) Michal Kubecek wrote: > Implement COALESCE_SET netlink request to set coalescing parameters of > a network device. These are traditionally set with ETHTOOL_SCOALESCE ioctl > request. This commit adds only support for device coalescing parameters, > not per queue coalescing parameters. > > Like the ioctl implementation, the generic ethtool code checks if only > supported parameters are modified; if not, first offending attribute is > reported using extack. > > Signed-off-by: Michal Kubecek Reviewed-by: Jakub Kicinski