Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] ipv4: fix a RCU-list lock in fib_triestat_seq_show
To:     David Miller <davem@davemloft.net>, cai@lca.pw
Cc:     kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, kuba@kernel.org,
        eric.dumazet@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200325220100.7863-1-cai@lca.pw>
 <20200326.202714.1221436401038064762.davem@davemloft.net>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <707e70a3-59f7-bc11-fd11-c5409e39c476@gmail.com>
Date:   Thu, 26 Mar 2020 22:41:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20200326.202714.1221436401038064762.davem@davemloft.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/26/20 8:27 PM, David Miller wrote:
> From: Qian Cai <cai@lca.pw>
> Date: Wed, 25 Mar 2020 18:01:00 -0400

>> Fix it by adding a pair of rcu_read_lock/unlock() and use
>> cond_resched_rcu() to avoid the situation where walking of a large
>> number of items  may prevent scheduling for a long time.
>>
>> Signed-off-by: Qian Cai <cai@lca.pw>
> 
> Eric, please review.
> 

Patch looks good to me, thanks !

Reviewed-by: Eric Dumazet <edumazet@google.com>