Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2210088ybb; Fri, 27 Mar 2020 00:55:35 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsyeZZy9/Ng9HmvedozExqoCUz4xsI2BNT6YALBq9k+nc9BDC1DygBOcHcx3RzYRr7SLBwm X-Received: by 2002:aca:2b04:: with SMTP id i4mr549691oik.177.1585295734891; Fri, 27 Mar 2020 00:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585295734; cv=none; d=google.com; s=arc-20160816; b=nQzsyimaNAdMec+9/0zgcvZcWn/KwftZQCcTD58OPrPridtN86er9Re/nLRP/eF9tv qzvBYXFbYTLF0Csj57fmOUTPBEoHHmw3MrJ6UYrK6lhQEied0aEaVn00gXxvYngqhShq E2GgNx4Ha6gcMyoCLHM9tL+2+PCvlmKXkHmFlilZIFwEVx394L5IPxYJ3IOvtVGApkhY g/Jy64doyP1I/GlmLT3Af5Md9LBWmoKi91KMQr88GxKS2D9MVx3zHNoA3J7YvDDOrTno tMjdogyAlJ1gO8Kz55fBDOgM+/tVmzyMXNHpBacA/gj3eVkYm3duZq7KInriuh8NX+lP 1geQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xUFFKgN3GfGwUoYxNVOvMRouA9N+GmIsWjhSsoKFX5E=; b=lpuis4XvWefO//WDbY4VxLgJ0nD1km8KvznDa2VeYserPtIGpKBW99Bq5ourOsrYOP zET+znTPar8RUP7UUTVix/TZhA896BFoFSlD9SaL/Ao7Z3rMT0H0P2O7Z6dWfkaQ4ejN vqo6/uHvEmzNrtNQxCN9VmNkCn2R5Qw0/gZgOqI0RkZWCQPQBS+sDCnBwPMdtwzdS3Qw 6dfFjKz76ybWfb8zI2bepHZ6jxij3zNqqf3MhFOCneSPrnSjwyQy3BbGd2DHDayRHbqv LoTw2+hp9nfsKkOYCGS3w4j5qHSiP+scdIB2pyHOQUYBb7m54AtDxZv8JIvdAethABuY TqgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y3cEWhLc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q23si2205378otm.79.2020.03.27.00.55.21; Fri, 27 Mar 2020 00:55:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y3cEWhLc; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726266AbgC0Hy4 (ORCPT + 99 others); Fri, 27 Mar 2020 03:54:56 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39213 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgC0Hyz (ORCPT ); Fri, 27 Mar 2020 03:54:55 -0400 Received: by mail-wr1-f66.google.com with SMTP id p10so10231522wrt.6 for ; Fri, 27 Mar 2020 00:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=xUFFKgN3GfGwUoYxNVOvMRouA9N+GmIsWjhSsoKFX5E=; b=Y3cEWhLcIOHEPTL/VkoGr5rmc2Y51cZVjR78PzBKRezoNIZvm5eHjjNQUgRpZin8GZ Z1d0WpYywAPdqlpPgLJM8M5Sh3JeSh+WIoW2weDwLhqoUcjZo+tvHfDH/x1c11ABky5O oEca0QR4lk/RKLO79mNgjPvRE1AL5spkEsGJPB6hCf0HY359JwyjQq5+zXCCHRuRhAfP 2Q8HPvqrvTxd0F5CqJC2J+kxaJ3jnCqZkJaa/pcmekjFJS013iuo25wMnzaZd2l1bA9/ jG3OxrmO2pHlA5Ny5H1gE60EraNsNzqVJSUeDOC65+V+7pKGqhaHUVJScP7ECzPPv0bb XkmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=xUFFKgN3GfGwUoYxNVOvMRouA9N+GmIsWjhSsoKFX5E=; b=E9zq+lWCJE84eV/IWWNrxXqM2SS/Tia0ZTvzda55+noHzmI2cjaULR8S8iNspkXON7 TQJ1NuEmTYagc0tUyqcfghqxaxiMhAKY4RXMUgTZ6oi9tir1Nz4caXILriDBGdb5OwNI rv+H0Jdvqlb+qORxU2Vm6RSDGoHy5gLnmhBLt+/1uVaskK2gMf1KtrZYjqG774BqAmGU OTiU6th1pS5h135ZIyOxbi8Bs7ZJu9V1yI/LgNhB0fx0kfFOoWywovAw7476pb3drwpA r5gcdn1WreG/8UyzTw8MBu0y8f/Brgwg8VSLlXLala6YMxewjMvo4eZso00JvKPUnC/e LdcQ== X-Gm-Message-State: ANhLgQ3a49JIPfKUvK4qmetLajbGuWD2vCtWq3UHTVz/fhPOzjVaBXJa A7r03S+pXvveAbsNBxsn8AzI1Q== X-Received: by 2002:adf:f7cb:: with SMTP id a11mr13341425wrq.79.1585295692174; Fri, 27 Mar 2020 00:54:52 -0700 (PDT) Received: from dell ([95.149.164.95]) by smtp.gmail.com with ESMTPSA id k9sm7684467wrd.74.2020.03.27.00.54.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Mar 2020 00:54:51 -0700 (PDT) Date: Fri, 27 Mar 2020 07:55:41 +0000 From: Lee Jones To: Saravanan Sekar Cc: robh+dt@kernel.org, jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v4 2/5] mfd: mp2629: Add support for mps battery charger Message-ID: <20200327075541.GF603801@dell> References: <20200322224626.13160-1-sravanhome@gmail.com> <20200322224626.13160-3-sravanhome@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200322224626.13160-3-sravanhome@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 22 Mar 2020, Saravanan Sekar wrote: > mp2629 is a highly-integrated switching-mode battery charge management > device for single-cell Li-ion or Li-polymer battery. > > Add MFD core enables chip access for ADC driver for battery readings, > and a power supply battery-charger driver > > Signed-off-by: Saravanan Sekar > --- > drivers/mfd/Kconfig | 9 +++ > drivers/mfd/Makefile | 2 + > drivers/mfd/mp2629.c | 116 +++++++++++++++++++++++++++++++++++++ > include/linux/mfd/mp2629.h | 22 +++++++ > 4 files changed, 149 insertions(+) > create mode 100644 drivers/mfd/mp2629.c > create mode 100644 include/linux/mfd/mp2629.h > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3c547ed575e6..6614e5cff881 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -434,6 +434,15 @@ config MFD_MC13XXX_I2C > help > Select this if your MC13xxx is connected via an I2C bus. > > +config MFD_MP2629 > + bool "Monolithic power system MP2629 ADC and Battery charger" > + depends on I2C > + select REGMAP_I2C > + help > + Select this option to enable support for monolithic power system > + battery charger. This provides ADC, thermal, battery charger power > + management functions on the systems. > + > config MFD_MXS_LRADC > tristate "Freescale i.MX23/i.MX28 LRADC" > depends on ARCH_MXS || COMPILE_TEST > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index f935d10cbf0f..d6c210f96d02 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -170,6 +170,8 @@ obj-$(CONFIG_MFD_MAX8925) += max8925.o > obj-$(CONFIG_MFD_MAX8997) += max8997.o max8997-irq.o > obj-$(CONFIG_MFD_MAX8998) += max8998.o max8998-irq.o > > +obj-$(CONFIG_MFD_MP2629) += mp2629.o > + > pcf50633-objs := pcf50633-core.o pcf50633-irq.o > obj-$(CONFIG_MFD_PCF50633) += pcf50633.o > obj-$(CONFIG_PCF50633_ADC) += pcf50633-adc.o > diff --git a/drivers/mfd/mp2629.c b/drivers/mfd/mp2629.c > new file mode 100644 > index 000000000000..41a4082387ce > --- /dev/null > +++ b/drivers/mfd/mp2629.c > @@ -0,0 +1,116 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * MP2629 MFD Driver for ADC and battery charger s/MFD Driver/parent driver/ > + * Copyright 2020 Monolithic Power Systems, Inc > + * > + * Author: Saravanan Sekar > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Alphabetical please. > +enum { > + MP2629_MFD_ADC, > + MP2629_MFD_CHARGER, > + MP2629_MFD_MAX > +}; > + > +static struct resource mp2629_irq_rsrc[] = { > + { > + .flags = IORESOURCE_IRQ, > + }, > +}; > + > +static struct mfd_cell mp2629mfd[] = { > + [MP2629_MFD_ADC] = { > + .name = "mp2629_adc", > + .of_compatible = "mps,mp2629_adc", > + }, > + [MP2629_MFD_CHARGER] = { > + .name = "mp2629_charger", > + .of_compatible = "mps,mp2629_charger", > + .resources = mp2629_irq_rsrc, > + .num_resources = ARRAY_SIZE(mp2629_irq_rsrc), > + } > +}; > + > +static const struct regmap_config mp2629_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = 0x17, > +}; > + > +static int mp2629_probe(struct i2c_client *client) > +{ > + struct mp2629_info *info; All this ddata instead of info. > + struct resource *resources; > + int ret; > + int i; > + > + info = devm_kzalloc(&client->dev, sizeof(*info), GFP_KERNEL); > + if (!info) > + return -ENOMEM; > + > + info->dev = &client->dev; > + i2c_set_clientdata(client, info); > + > + info->regmap = devm_regmap_init_i2c(client, &mp2629_regmap_config); > + if (IS_ERR(info->regmap)) { > + dev_err(info->dev, "Failed to allocate regmap!\n"); > + return PTR_ERR(info->regmap); > + } > + > + for (i = 0; i < MP2629_MFD_MAX; i++) { > + mp2629mfd[i].platform_data = &info->regmap; > + mp2629mfd[i].pdata_size = sizeof(info->regmap); You don't need to store this in platform data as well. You already have it in device data (ddata [currently 'info']). > + resources = (struct resource *)mp2629mfd[i].resources; > + if (resources) { > + resources[0].start = client->irq; > + resources[0].end = client->irq; > + } You don't need to store this separately either. Just fetch it from the parent in the child device driver. It will look something like (untested, off the top of my head): platform_get_irq(to_platform_device(pdev->dev.parent), 0); > + } > + > + ret = devm_mfd_add_devices(info->dev, PLATFORM_DEVID_NONE, mp2629mfd, > + ARRAY_SIZE(mp2629mfd), NULL, > + 0, NULL); > + if (ret) > + dev_err(info->dev, "Failed to add mfd %d\n", ret); "Failed to register sub-devices" > + return ret; > +} > + > +static const struct of_device_id mp2629_of_match[] = { > + { .compatible = "mps,mp2629"}, > + { } > +}; > +MODULE_DEVICE_TABLE(of, mp2629_of_match); > + > +static const struct i2c_device_id mp2629_id[] = { > + { "mp2629", }, > + { } > +}; > +MODULE_DEVICE_TABLE(i2c, mp2629_id); You're already using .probe_new - this can be removed. > +static struct i2c_driver mp2629_driver = { > + .driver = { > + .name = "mp2629", > + .of_match_table = mp2629_of_match, > + }, > + .probe_new = mp2629_probe, > + .id_table = mp2629_id, > +}; > +module_i2c_driver(mp2629_driver); > + > +MODULE_AUTHOR("Saravanan Sekar "); > +MODULE_DESCRIPTION("MP2629 Battery charger mfd driver"); "parent driver" > +MODULE_LICENSE("GPL"); > diff --git a/include/linux/mfd/mp2629.h b/include/linux/mfd/mp2629.h > new file mode 100644 > index 000000000000..371e44330ba8 > --- /dev/null > +++ b/include/linux/mfd/mp2629.h > @@ -0,0 +1,22 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * mp2629.h - register definitions for mp2629 charger Remove the filename. s/mp2629/MP2629/ > + * Copyright 2020 Monolithic Power Systems, Inc > + * Superfluous '\n'. > + */ > + > +#ifndef __MP2629_H__ > +#define __MP2629_H__ > + > +#include > + > +struct device; > +struct regmap; Why not just add the includes? > +struct mp2629_info { > + struct device *dev; > + struct regmap *regmap; > +}; > + > +#endif -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog