Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: O0VdjnI9LQPCEkcvwaasvAmuaPdXKrbIYmRmzSYmJAxhk3qKdojS4JNzs2hUftE+8DhnPkYKEq
 RX4c/xn9pnfA==
IronPort-SDR: u4frG0uSJN+vFDVpxGHihJ1Q16T8vGQuvgR7gytmxAV6sosToqdUB1gim9Er7CrTTAvx7Dw32W
 OlrGg4O+ohzw==
From:   Alexander Shishkin <alexander.shishkin@linux.intel.com>
To:     roman.sudarikov@linux.intel.com, peterz@infradead.org,
        mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        jolsa@redhat.com, namhyung@kernel.org,
        linux-kernel@vger.kernel.org, eranian@google.com,
        bgregg@netflix.com, ak@linux.intel.com, kan.liang@linux.intel.com
Cc:     alexander.antonov@intel.com, roman.sudarikov@linux.intel.com,
        alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v8 2/3] perf x86: Topology max dies for whole system
In-Reply-To: <20200320073110.4761-3-roman.sudarikov@linux.intel.com>
References: <20200320073110.4761-1-roman.sudarikov@linux.intel.com> <20200320073110.4761-3-roman.sudarikov@linux.intel.com>
Date:   Fri, 27 Mar 2020 10:01:23 +0200
Message-ID: <87bloi6xbg.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

roman.sudarikov@linux.intel.com writes:

> From: Roman Sudarikov <roman.sudarikov@linux.intel.com>
>
> Helper function to return number of dies on the platform.

It's not a function though, it's a macro. And maybe more of an
"accessor" than a "helper".

It's also good to mention in the commit message, why this change is
needed and sometimes (though maybe not here) why this way is better than
the alternatives.

Another thing about the subject line is that it has to describe the
action that the patch is taking, in imperative mood. In this case it
could be "Turn the max die calculation into a function".

The prefix of the subject line should be: perf/x86/intel/uncore. Check
out git log arch/x86/events/intel/uncore.c for examples.

I also think that it won't be unreasonable to fold this patch into the
next one. That's up to you, of course.

Regards,
--
Alex