Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [v4,1/3] drm/prime: use dma length macro when mapping sg
To:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Shane Francis <bigbeeshane@gmail.com>,
        dri-devel@lists.freedesktop.org
Cc:     airlied@linux.ie, linux-kernel@vger.kernel.org,
        amd-gfx-request@lists.freedesktop.org, alexander.deucher@amd.com
References: <20200325090741.21957-2-bigbeeshane@gmail.com>
 <CGME20200327075458eucas1p2f1011560c5d2d2a754d2394f56367ebb@eucas1p2.samsung.com>
 <4aef60ff-d9e4-d3d0-1a28-8c2dc3b94271@samsung.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <82df6735-1cf0-e31f-29cc-f7d07bdaf346@amd.com>
Date:   Fri, 27 Mar 2020 09:11:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
In-Reply-To: <4aef60ff-d9e4-d3d0-1a28-8c2dc3b94271@samsung.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:be8a:bd56:1f94:86e7] (2a02:908:1252:fb60:be8a:bd56:1f94:86e7) by FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Fri, 27 Mar 2020 08:11:56 +0000
X-Originating-IP: [2a02:908:1252:fb60:be8a:bd56:1f94:86e7]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ccbc7e0a-7416-4c8d-8202-08d7d22684ba
X-MS-TrafficTypeDiagnostic: DM6PR12MB3434:|DM6PR12MB3434:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB34348A70078B9AF6F2ABA81583CC0@DM6PR12MB3434.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-Forefront-PRVS: 0355F3A3AE
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(186003)(2906002)(53546011)(66556008)(2616005)(66476007)(16526019)(66946007)(81156014)(8676002)(8936002)(36756003)(110136005)(6486002)(52116002)(31686004)(6666004)(81166006)(5660300002)(4326008)(478600001)(316002)(86362001)(31696002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB3434;H:DM6PR12MB4401.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: yQxyOtsHmE42GbsrP8f0XBhN5qbfFGqa0o0neMdiWxJSDVWNylh5U46O4PJn6ASTDEgjL/FWQgXCkXvrnuNYHyHpyqgcJ8/2Kla3K6+jQYUgdw0F8qGbH/Oj9Fuf9NYkCGSqifJBpMyRX7AsaP7v/xYh8bEoCHo15dVEAb4vT6esMifDllpdF8WsUcT1kF1Cn1zLjP7jtdfpepB9DqaBw4UIE0OtCnCEl2kMAx9DAj3oqz62HYo8NcESILCib6zzlG3SuN4Br4ls1SQPrCbe8GcivvWcGP0S9Dy/fP1/UIoctzDjdzSRbqZTa+qT/0YMUSpkRS3TnVM7ykKs4hFH4f+QUQZ11eXT/yJHOQ7W4c3csuoZgznx+kpAOBIqQmoLqdSx3Op38Bo4wJCCrk/hv8ejoQm5HJ20V2XENAkCgYSsbmf/KYsKy4oEG/6l9EtM
X-MS-Exchange-AntiSpam-MessageData: NKCC1pf/s/sLh4ovCZV53iiA9CWgmofkGup1YvdRqZ9ZPkRIRmIGYr6GQwv0bl39pmNGfYPZaP6mUWHFis4oFMJP092VpoGZ52nqt0SRPP7mbEOfHN8+drchC6m7BCwi7tbm2jf5sBqcmP30cBMXz3VRm7jookRrPSgjWiPZ/jh7FbaFNUlbcDlrQ3wpO2/gzbJ2uVb/ovjC5s0mrNj5mg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ccbc7e0a-7416-4c8d-8202-08d7d22684ba
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2020 08:11:57.9096
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MgNWpSTxxCawu9vyzrlFlGMyzkXyL/NpbcywY+hPtkLvgve87GDJzPoL7JVcLZLi
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3434
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 27.03.20 um 08:54 schrieb Marek Szyprowski:
> Hi All,
>
> On 2020-03-25 10:07, Shane Francis wrote:
>> As dma_map_sg can reorganize scatter-gather lists in a
>> way that can cause some later segments to be empty we should
>> always use the sg_dma_len macro to fetch the actual length.
>>
>> This could now be 0 and not need to be mapped to a page or
>> address array
>>
>> Signed-off-by: Shane Francis <bigbeeshane@gmail.com>
>> Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
> This patch landed in linux-next 20200326 and it causes a kernel panic on
> various Exynos SoC based boards.
>> ---
>>    drivers/gpu/drm/drm_prime.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
>> index 86d9b0e45c8c..1de2cde2277c 100644
>> --- a/drivers/gpu/drm/drm_prime.c
>> +++ b/drivers/gpu/drm/drm_prime.c
>> @@ -967,7 +967,7 @@ int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct page **pages,
>>    
>>    	index = 0;
>>    	for_each_sg(sgt->sgl, sg, sgt->nents, count) {
>> -		len = sg->length;
>> +		len = sg_dma_len(sg);
>>    		page = sg_page(sg);
>>    		addr = sg_dma_address(sg);
>>    
> Sorry, but this code is wrong :(

Well it is at least better than before because it makes most drivers 
work correctly again.

See we only fill the pages array because some drivers (like Exynos) are 
still buggy and require this.

Accessing the pages of an DMA-buf imported sg_table is illegal and 
should be fixed in the drivers.

> [SNIP]
>
> I will send a patch in a few minutes with the above fixed code.

That is certainly a good idea for now, but could we also put on 
somebodies todo list an item to fix Exynos?

Thanks in advance,
Christian.

>
> Best regards