Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: OnXpwTSIoicTCA8WTE40yq6c6kAu7Imqz+buhBZPypQb1g6jAnoXkfNvuDeW5W6gqBT4IKqC8v
 DVVhKSsKRRfA==
IronPort-SDR: i+hVpidsIamRPL6dWnx9MuIyD/acz2sgM6HC/0Pp3xauKM9JmnWBYYehrhx5ZTdNgZAahA5Dn5
 lAwtIF7YrTmw==
From:   Alexander Shishkin <alexander.shishkin@linux.intel.com>
To:     roman.sudarikov@linux.intel.com, peterz@infradead.org,
        mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com,
        jolsa@redhat.com, namhyung@kernel.org,
        linux-kernel@vger.kernel.org, eranian@google.com,
        bgregg@netflix.com, ak@linux.intel.com, kan.liang@linux.intel.com
Cc:     alexander.antonov@intel.com, roman.sudarikov@linux.intel.com,
        alexander.shishkin@linux.intel.com
Subject: Re: [PATCH v8 3/3] perf x86: Exposing an Uncore unit to PMON for
 Intel =?utf-8?Q?Xeon=C2=AE?= server platform
In-Reply-To: <20200320073110.4761-4-roman.sudarikov@linux.intel.com>
References: <20200320073110.4761-1-roman.sudarikov@linux.intel.com> <20200320073110.4761-4-roman.sudarikov@linux.intel.com>
Date:   Fri, 27 Mar 2020 10:47:56 +0200
Message-ID: <875zeq6v5v.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

roman.sudarikov@linux.intel.com writes:

> ---
>  .../ABI/testing/sysfs-devices-mapping         |  33 +++
>  arch/x86/events/intel/uncore.h                |   9 +
>  arch/x86/events/intel/uncore_snbep.c          | 191 ++++++++++++++++++
>  3 files changed, 233 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-devices-mapping
>
> diff --git a/Documentation/ABI/testing/sysfs-devices-mapping b/Documentation/ABI/testing/sysfs-devices-mapping
> new file mode 100644
> index 000000000000..16f4e900be7b
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-mapping

Is this a good place for something that's perf/x86/intel/uncore
specific?

> +                Which means:
> +                IIO PMU 0 on die 0 belongs to PCI RP on bus 0x00, domain 0x0000
> +                IIO PMU 0 on die 1 belongs to PCI RP on bus 0x40, domain 0x0000
> +                IIO PMU 0 on die 2 belongs to PCI RP on bus 0x80, domain 0x0000
> +                IIO PMU 0 on die 3 belongs to PCI RP on bus 0xc0, domain 0x0000
> \ No newline at end of file

Git is trying to tell you something.

> +		eas[die].attr.attr.mode = 0444;

I believe this one is also known as S_IRUGO.

Other than that, this patch is

Reviewed-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>

Regards,
--
Alex