Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp2249853ybb; Fri, 27 Mar 2020 01:54:19 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuoyfFGybyiW3hgWMSDpqX7lRPXoTrEnDZ79o5HdaKljYSWuLqnvAeCD36I3r9KuTjlqWaF X-Received: by 2002:aca:eb4e:: with SMTP id j75mr3306301oih.18.1585299259099; Fri, 27 Mar 2020 01:54:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585299259; cv=none; d=google.com; s=arc-20160816; b=sC/O0AfoNRETEPUiUjvC9ZviQffplbs8edV/lYk1QAw9M1OvF+6m8+Wc4sZRSrlxC1 SQYCsoKDx5DHKmxk7Alu3oo7C/wHZljr9lNM2IoNBSrnhkmRlb1dbwgCKHpapYLMxLkE j3WMafHw2yBBfzmibJjaE0XPeLESZ0nSADeZL7cT4FdeHxmW2/mNszDTR8B35V831vN3 X4KifXpzdBi6i88KJdWIYCCJl4gqoPLI97YHXATmXBqGEgyN/uual0Xhubr8U8WT2Qs6 1S+Ye/thuKmZBNeI+BZIAsfWUbqV1EHiSVqXTzLokVlrGA/Q4GV/mfOAL7nzDAHKZqQA mcpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=R6RZiXEcIsLToTYFi1sESEyU5BX8rS5/YP6936j2TZs=; b=zhuu3B5C8kwY9hCWc8b8rIsEGMOlxelE02xTHU/0oUU7Hwaf2F3uT76Kriar3eynJa yQfqdO4YFroYnctSP64LHnNkpSLODRstBjxkRUP9RWewAVg1mU4uloNCWoqwQYri8DCe 6QtYbFMgR6IhgAWSGDbKkoMGn4JZ6+50+JnS+fiEPK0hF7C8F/bk7kgRVqg1wT3kULb/ o5bmJZKE322eCfce35vr5WP3bLrpPt73TXiHVu6LZAEBpciZRV+sl/yYXyBcMfu9kI1+ 7uJhfihNPTNMNHtd0hNn3D3pEg2FVqveV7oIJlMSZDvyCJWVJihQzviGEG+A3CzNGCxW PIeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=RMaN69VB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v9si2161877oib.201.2020.03.27.01.54.06; Fri, 27 Mar 2020 01:54:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cogentembedded-com.20150623.gappssmtp.com header.s=20150623 header.b=RMaN69VB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726275AbgC0Ixe (ORCPT + 99 others); Fri, 27 Mar 2020 04:53:34 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:41087 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgC0Ixe (ORCPT ); Fri, 27 Mar 2020 04:53:34 -0400 Received: by mail-lj1-f196.google.com with SMTP id n17so9351775lji.8 for ; Fri, 27 Mar 2020 01:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R6RZiXEcIsLToTYFi1sESEyU5BX8rS5/YP6936j2TZs=; b=RMaN69VBVbnZ6XLul4Z0c1rp0GoPJlXhEEXjeth0ysbXcs/RJUX/UOS51jg6dk+nRn L1ydMdtag3eLejmn2W173HzX8HGhLKJx4wVbcyP6AUyOcwe0tw1cQKLdvUBdARG6XWn/ X+JED/o48CSCpvOyW9/x8yjaq7b+gVd9q37s8I1OEMD9mZl5rm5ch3CekchcsHXeIh9Q gahgxQfxL3CvjvwNQv/m3SfZ3rA7ib5ZFcmfX13vUqHMJsuQs+lnFsr358PmmbflVbGv WIcIkefmFLSK3gjvhiCxvHBCSSie2Lc9UTITIf81pUiVJr8U+UY80/W752lQ2HdfWJqz WHdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R6RZiXEcIsLToTYFi1sESEyU5BX8rS5/YP6936j2TZs=; b=XQGwZuhkrAA+NOicqbcvl1TH3dW1xeSnG+WeWX+7QCg3Tc9bjMbMV8oqxAqmv/jGDQ Uweiljcd/7hc3XVCDvun8rTPMOwm9713vctiSHibyOKUrjNpc9I4v19lABx7f5iKmI8y htmRukTI59NTUQSeWsyWamJj5O68gTyL4QP7HlDyaGeKF9gPOANZa0wANs3oWOpHXZuW d2RVGH4rdXmdBgoXCIFxg5sYIMvMrTYJj0iffMvGm8/83GwSks7ISakORo1EctUCMsYA hiUKWGpsV5QElStBmHjJoWb6Q5Nts3I2aV0fdFOu9pOyvp7JAfKQ78thlJGfs4wWcJE6 B6yg== X-Gm-Message-State: ANhLgQ1yTadzYclBsvWy4j2oqRcSvqmHvmRJ4KPOopBZkTHQ2ZRfz3uY krj+DM3pKdz0frBPSxghRLcBHL5bx95VGg== X-Received: by 2002:a2e:b554:: with SMTP id a20mr7841807ljn.34.1585299210596; Fri, 27 Mar 2020 01:53:30 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:489c:7e29:1184:adc3:6cdd:61c2? ([2a00:1fa0:489c:7e29:1184:adc3:6cdd:61c2]) by smtp.gmail.com with ESMTPSA id v19sm3007695lfg.9.2020.03.27.01.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2020 01:53:30 -0700 (PDT) Subject: Re: [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints To: Michael Grzeschik , lars@metafoo.de, alexandru.Ardelean@analog.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, balbi@kernel.org Cc: gregkh@linuxfoundation.org, bigeasy@linutronix.de, m.olbrich@pengutronix.de, kernel@pengutronix.de References: <20200327084302.606-1-m.grzeschik@pengutronix.de> From: Sergei Shtylyov Message-ID: <035d6582-b513-2ebd-f755-325df52e6a10@cogentembedded.com> Date: Fri, 27 Mar 2020 11:53:18 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200327084302.606-1-m.grzeschik@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 27.03.2020 11:43, Michael Grzeschik wrote: > dwc3_gadget_ep_disable gets called before the last request gets > dequeued. > > In __dwc3_gadget_ep_disable all started, pending and cancelled > lists for this endpoint will call dwc3_gadget_giveback in > dwc3_remove_requests. > > After that no list containing the afterwards dequed request, Dequeued. > therefor it is not necessary to run the dequeue routine. Therefore? > Signed-off-by: Michael Grzeschik [...] MBR, Sergei